search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
163 stars 89 forks source link

Update ppdippstr.py #104

Closed LAfricain closed 6 years ago

LAfricain commented 6 years ago

New strings internationalized for the ppd.

zdohnal commented 6 years ago

Hi, I'm sorry for being late - the patch looks generally ok to me, but would you mind keeping english in commentary at l. 96? And is this merge request different than #109 ? It looks quite similar to me.

LAfricain commented 6 years ago

I'm sorry for being late

No problem :)

And is this merge request different than #109 ?

I should be very similar, but I'm a newbie with git, and I had difficulties why the pull, rebase... For this reason I begun from scratch. Thanks for the merge. Now I will translate the po.

zdohnal commented 6 years ago

Sorry, I didn't merge it yet - would you mind correcting the issue mentioned in my previous comment?

LAfricain commented 6 years ago

Oh yes sorry. I'll come back.

LAfricain commented 6 years ago

Correction done, pull request #109 should be merge (not yet #104 )

LAfricain commented 6 years ago

Hello, Please update the po files for new strings in ppdippstr.py.Thanks