OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
164 stars 90 forks source link

fix for autoconf 2.70 needed #201

Closed andyrtr closed 3 years ago

andyrtr commented 3 years ago

With recent autoconf 2.70 you will get this error when running autoreconf -vfi:

configure.ac: error: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION

I could solve it adding this small patch. Not sure if gettext 0.21 is needed or even an older version would do it.


+++ system-config-printer-1.5.14/configure.ac.new       2021-01-06 10:38:51.997694866 +0100
@@ -3,6 +3,7 @@
 AM_INIT_AUTOMAKE([dist-xz dist-bzip2 subdir-objects 1.6])
 IT_PROG_INTLTOOL
 AM_GNU_GETTEXT([external])
+AM_GNU_GETTEXT_VERSION(0.21)
 AM_PATH_PYTHON([3])
 PACKAGE="AC_PACKAGE_NAME"
 VERSION="AC_PACKAGE_VERSION"```

And please add the missing README file to avoid another autotools error. I've added "touch README" to our Arch packaging script for a long time.
zdohnal commented 3 years ago

Hi @andyrtr ,

thank you for reporting the issue!

My Fedora rawhide has only autoconf 2.69, would you mind testing if adding the following line in configure.ac works?

AM_GNU_GETTEXT_VERSION([0.18.3])

I chose this version because it is the same version as cups-filters requires and I would like to require the same version as other projects of printing stack.

andyrtr commented 3 years ago

Works well too here.

zdohnal commented 3 years ago

Fixed on the current master.

Thank you for the report and testing!