search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
156 stars 87 forks source link

build: Port to meson build system #239

Closed inigomartinez closed 2 years ago

inigomartinez commented 2 years ago

meson is a build system focused on speed an ease of use, which helps speeding up the software development. This patch adds meson support along autotools.

zdohnal commented 2 years ago

Hi Inigo,

thank you for your work on the pull request, but I only keep system-config-printer in maintenance, so I don't usually accept PRs for new functionality (unless it is critical for working with new CUPS which will come in the future).

IMO Meson support isn't critical to have it since the project has the other means of setup, so I'm going to close the PR.

However, if you are interested in system-config-printer, I can arrange adding you as a member for developing system-config-printer, and you can focus on development of new features. Do let me know if you're interested.

zdohnal commented 2 years ago

Inigo, it would be great if you answered by a comment instead of 'thumbs up'. I'm not sure whether you are just okay with my reasoning and with closing the PR, or do you want to become co-maintainer of system-config-printer.

inigomartinez commented 2 years ago

Inigo, it would be great if you answered by a comment instead of 'thumbs up'. I'm not sure whether you are just okay with my reasoning and with closing the PR, or do you want to become co-maintainer of system-config-printer.

I'm sorry, I didn't thought that you were expecting a specific answer.

I have been porting several gnome and freedesktop packages to meson and gettext for sometime now and I learned about system-config-printer through this issue , where they are trying to get rid of intltool.

I though that it could be helpful to move system-config-printer to meson and then move it to gettext. Actually, I didn't really have in mind to get involved in development, sorry, so I'm ok with your reasoning, so I'll just close the PR.

Thank you for giving it a though.

zdohnal commented 2 years ago

@inigomartinez thanks for letting me know!

Aha, so intltool is going away and is completely replaced by gettext - I would have been happy to merge a PR regarding the migration, if such a PR arrived.

inigomartinez commented 2 years ago

Migration from intltool to gettext: #243