search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
156 stars 87 forks source link

Accessibility improvements #244

Closed vvillenave closed 1 year ago

vvillenave commented 2 years ago

Greetings everybody,
I’ve been working on making this program fully usable by visually-impaired users;
this is what I’m coming up with so far; a big stumbling block remains the troubleshooter,
but I’m hoping to offer a fix in the future about that.

vvillenave commented 2 years ago

(See also #220 in Orca for that troubleshooter issue.)

zdohnal commented 2 years ago

Hi @vvillenave ,

thank you for the PR!

It would be great if you provided a list of changes which I should look for when testing the PR. Would you mind telling me what should I check when I'll testing the PR to make sure it works correctly?

vvillenave commented 2 years ago

Greetings @zdohnal, sure!
To test it, you’ll need to enable a screen reader (such as Orca) or any app
that allows you to browse the At-Spi tree (such as Accerciser).

First, you can open the “Printer properties” dialog and, without using the mouse,
hit Tab a bunch of times to browse through the available fields. Many of these items
were previously not correctly labelled: for example you’d hear “HP DeskJet xxx” but
not “Make and Model”. Now you hear the correct labels in the correct order.

Likewise, the Printer window (the icon view) previously wouldn’t tell you what was focused:
if you have several printers and move from one to another using the keyboard’s arrows,
all Orca would tell you is “Icon… Icon… Icon…”. With this PR it’ll tell you the brand and model,
just like what you can see printed below.

zdohnal commented 2 years ago

Thank you for the info @vvillenave ! I'll test it once I get into system-config-printer again. Now I'm busy with other responsibilities, sorry :(

vvillenave commented 2 years ago

Nice: that Orca bug I mentioned has been fixed in the meantime.
So now it’s up to you @zdohnal, whenever you find a bit of time :-)

vvillenave commented 2 years ago

Greetings @zdohnal, a happy new year to you! Any chance of seeing this PR merged?

zdohnal commented 2 years ago

Hi @vvillenave ,

I'm really sorry... I haven't got into testing it so far :( but I have it in my log.

zdohnal commented 1 year ago

Hi @vvillenave ,

I'm sorry for long delay, but I was able to reproduce the issue (I heard the incorrect naming by orca) and I verified your PR fixed the issue.

Thank you so much for the patch and patience!