search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
156 stars 87 forks source link

Support GNOME 42 dark style preference #263

Closed jbicha closed 2 years ago

jbicha commented 2 years ago

Adds an optional dependency on libhandy >= 1.5

Here's a developer blog post about the feature.

zdohnal commented 2 years ago

Hi @jbicha ,

thank you for the PR!

So IIUC s-c-p currently does not honor the dark style at all, since its background is always light. Then if we use PREFER_LIGHT in s-c-p, the s-c-p background will be dark only if system background is set to dark.

I've verified the PR based on the conclusions mentioned above - s-c-p has light background with light system background and dark with dark background - merging the PR.

Thank you for the contribution!