search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
163 stars 90 forks source link

ci(lint): add shell linter - Differential ShellCheck #284

Closed jamacku closed 2 years ago

jamacku commented 2 years ago

Differential ShellCheck is a GitHub action that performs differential ShellCheck scans on shell scripts changed via PR and reports results directly in PR. The beauty of differential scans is that you will get reports only about newly added defects.

Since this repository has few shell scripts, I think you might find some value in having a shell linter. Differential ShellCheck action is able to produce reports in SARIF format. GitHub understands this format and is able to display it nicely as a PR comment, and on the Files Changed tab, please see below.

image

image

Documentation is available at @redhat-plumbers-in-action/differential-shellcheck. Let me know If you are missing some feature or setting. I'm always happy to extend functionality.

Note: I have also added Dependabot to keep your workflows up to date

/cc @zdohnal

zdohnal commented 2 years ago

Hi @jamacku ,

thank you for the pull request!

It looks good to me, I'll add it to the system-config-printer project.