search

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration
GNU General Public License v2.0
155 stars 87 forks source link

TypeError in JobViewer.auth_info_dialog_response() #324

Closed khaeru closed 1 month ago

khaeru commented 1 year ago

I see the following in journalctl -f:

Jun 02 10:33:50 khaeru-laptop gnome-shell[1108886]: Caught non-fatal exception.  Traceback:
Jun 02 10:33:50 khaeru-laptop gnome-shell[1108886]: File "/usr/share/system-config-printer/jobviewer.py", line 1199, in auth_info_dialog_response
Jun 02 10:33:50 khaeru-laptop gnome-shell[1108886]:     debugprint ("keyring: created id %d for %s" % (id, name))
Jun 02 10:33:50 khaeru-laptop gnome-shell[1108886]:                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
Jun 02 10:33:50 khaeru-laptop gnome-shell[1108886]: TypeError: %d format: a real number is required, not builtin_function_or_method
Jun 02 10:33:50 khaeru-laptop gnome-shell[1108886]: Continuing anyway..

…in Ubuntu 22.04, with system-config-printer version 1.5.18-1ubuntu1.

The erroneous line seems to be the same on master: https://github.com/OpenPrinting/system-config-printer/blob/826fb0e171ded92407c60d1754d5807d5487e6b2/jobviewer.py#L1199

This seems to be due to d05c82a7e271c2a3bfa191e271c5fbd8b21b5066 / #67.

Gmin2 commented 5 months ago

@khaeru can i work on it

zdohnal commented 5 months ago

Hi @Min2who ,

yes, feel free to send PR.