Do not start the applet on GNOME and Cinnamon desktops (Closes: #40)

OpenPrinting / system-config-printer

Graphical user interface for CUPS administration

GNU General Public License v2.0

170 stars 89 forks source link

Do not start the applet on GNOME and Cinnamon desktops (Closes: #40) #41

Closed bigon closed 7 years ago

bigon commented 8 years ago

{gnome,cinnamon}-settings-daemon are also claiming the D-Bus interfaces provided by the applet

bigon commented 8 years ago

The tests are failing, but according to https://standards.freedesktop.org/menu-spec/latest/apb.html, Cinnamon is a valid name

bigon commented 8 years ago

Ping? Any reasons this has not been merged?

jbicha commented 7 years ago

@bigon The check is failing because the travis config is set to use Ubuntu 12.04 LTS "Precise" and desktop-file-utils in that version did not recognize Cinnamon. Ubuntu 12.04 is no longer supported so that should be updated to at least 14.04 LTS but I personally would recommend 16.04 LTS unless there's a particular need for this package to support a 3 year old stack.

@zdohnal Could you please review this pull request?

jbicha commented 7 years ago

Oh, Travis doesn't support 16.04 LTS yet. :-1:

bigon commented 7 years ago

The test is passing now, could you please consider merging this?

jbicha commented 7 years ago

For some reason, I often don't get emails from Github so I'm going to try pinging @zdohnal directly. :)

zdohnal commented 7 years ago

Hi,

sorry for late response, I'll merge it.