Radio Station PRO: Layout occasionally breaks after enabling Continuous Playback

[gusaus]

Describe the bug I'm testing Radio Station PRO and the sticky player. When navigating the site some of the pages don't load with the correct layout. For instance, the archive pages load the sidebar content underneath the body.

I've tested with all Newspack plugins and dependencies disabled (just Radio Station enabled) and the issue remains.

To Reproduce Steps to reproduce the behavior:

1. Enable Sitewide Bar Player w/ Continuous Playback Enabled
2. Click categories in the right sidebar (https://radio-openproducer-platform.pantheonsite.io/music/, https://radio-openproducer-platform.pantheonsite.io/news/, https://radio-openproducer-platform.pantheonsite.io/tech/, etc.)
3. Scroll down page
4. Sidebar content will sometimes appear under the body

Expected behavior Widgets should load and appear in the right sidebar

Screenshots See video - https://monosnap.com/file/clFqns4DWoq9UzlkypxD0yxjToyzr4

Desktop (please complete the following information):

• OS: macOS
• Browser Firefox
• Version 91.0.1

Additional context I've also switched to the Make theme and experience the same issue...although it happens less frequently. Currently the Make theme is enabled on https://radio-openproducer-platform.pantheonsite.io/

I also realize you use the Make theme on RadioStationDemo.com and don't experience the same issues.

When Continuous Playback is disabled, the issue goes away.

That said, I'm wondering @majick777 if you had any idea what I could do to troubleshoot. Do you think this is Newspack theme-specific or possibly a configuration issue on my part?

Ideally, we could get this working with the Newspack theme as it's the base theme for OpenProducer. I'd be happy to test and troubleshoot if someone can point me in the right direction.

Thanks

[majick777]

@gusaus Thanks for this... It looks to be that for some reason the body classes are not added by Make in the transitioned-to window. Since Make controls the layout via media queries based on the body classes, it is stacking the sidebar instead of giving it the width it needs.

As you say though, seems to be working on the demo site... so can I first just double check which version of Pro you have installed? As It may be different to what is on the demo site. Since both are on Make this is te first thing to eliminate.

Also, the Teleporter library that is used I have released as a standalone plugin, and I have just done a bit of an update on it, which will be part of the next Pro release, so you could always test with that: https://wordpress.org/plugins/teleporter/

[gusaus]

Hi @majick777 - Good to know it's not total ineptitude in configuration on my part. Right now I'm just testing with a stream urls from Airtime, LibreTime, and AzuraCast... just seeing if it plays (which it does!).

I'm testing Radio Sation PRO Version 2.4.1.3.

Assuming it's the same version @tonyzeoli is working with on the demo site.

I switched back to the Newspack base theme just in case you'd like to see if it's the same issue where the body classes are not added.

Test - https://radio-openproducer-platform.pantheonsite.io/ https://radio-openproducer-platform.pantheonsite.io/music/ https://radio-openproducer-platform.pantheonsite.io/news/ https://radio-openproducer-platform.pantheonsite.io/tech/

I'll test out https://wordpress.org/plugins/teleporter/ tomorrow if you think it could help. Very cool you're releasing a stand alone plugin for the bleeding edge stuff you're working on!

[majick777]

@gusaus Looks like Newspack is not having the same problem, the body classes are there fine. So is a bit of a mystery still... the classes seem to be there in the frame on pageload, just to disappear later... ...no, umm, mystery solved! I just compared Teleporter 0.9.8 with 1.0.0 and can see I already fixed this. :-) There was a point in the code where the body classes were reset instead of just the teleporter-loading class being removed. If you test with Teleporter 1.0.0 and Make you can confirm... But I am just putting the finishing touches on Pro 2.4.1.4 which includes this version of Teleporter anyway.

[tonyzeoli]

Glad you all got this sorted out!

On Tue, Aug 24, 2021 at 1:24 AM majick777 @.***> wrote:

@gusaus https://github.com/gusaus Looks like Newspack is not having the same problem, the body classes are there fine. So is a bit of a mystery still... the classes seem to be there in the frame on pageload, just to disappear later... ...no, umm, mystery solved! I just compared Teleporter 0.9.8 with 1.0.0 and can see I already fixed this. :-) There was a point in the code where the body classes were reset instead of just the teleporter-loading class being removed. If you test with Teleporter 1.0.0 and Make you can confirm... But I am just putting the finishing touches on Pro 2.4.1.4 which includes this version of Teleporter anyway.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/netmix/openproducer-platform/issues/44#issuecomment-904332444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA65WO3FYW6L77NTBINUNTDT6MUH7ANCNFSM5CVAFLZQ .

-- Sent from Gmail Mobile

[gusaus]

Thanks @majick777!

I was testing with Teleporter and then noticed Radio Station PRO Version 2.4.1.4 was just released. So I disabled Teleporter and am now testing Radio Station PRO.

There seems to be a new strange issue where the player is also reloading/fading in everytime you go to a new page. I thought this may have something to do with Teleporter being enabled, so I disabled and deleted. That did not fix the issue.

You should be able to replicate the behavior clicking around here - https://radio-openproducer-platform.pantheonsite.io/

Also - I'm seeing the following warning at the top of the Radio Station settings page - not sure if it's related -

Warning: count(): Parameter must be an array or an object that implements Countable in /code/wp-content/plugins/radio-station-pro-premium/includes/rsp-role-interface.php on line 260 Warning: Invalid argument supplied for foreach() in /code/wp-content/plugins/radio-station-pro-premium/includes/rsp-role-interface.php on line 261 Warning: count(): Parameter must be an array or an object that implements Countable in /code/wp-content/plugins/radio-station-pro-premium/includes/rsp-role-interface.php on line 284 Warning: Invalid argument supplied for foreach() in /code/wp-content/plugins/radio-station-pro-premium/includes/rsp-role-interface.php on line 285

[gusaus]

Here's a screengrab of an archive page still not loading correctly (along with another warning).

[gusaus]

...and of course several hours later I'm testing and the player is 'not' reloading/fading as you navigate. Some pages are still not loading properly https://github.com/netmix/openproducer-platform/issues/44#issuecomment-905039838 but it's much better than before!

[majick777]

@gusaus I'm confused by this. That warning about line 99 made sense for the older version, but has been fixed in the newer version, and besides that, line 99 of teleporter.php that is included in 2.4.1.4 now has a completely different function in it... Do you have any caching activated or something? Really makes no sense to me to see this. :-?

Thanks for the quick pickup of the warnings regarding the role interface. I did do some updates to fix that, but I seem to have missed those warnings in my testing. The actual functionality is working correctly though, where it wasn't quite before.

I did check the open producer test site and the player is fading in with the new page fine for me... There was a request for a change that the player not fade in after the page has loaded like it does on the initial page load, but rather fade in with the new page, which makes sense, and that is the behaviour that I see now. So can you be more specific in what you mean by something "not" happening when you navigate? As again, it's working as expected for me.

One thing I did just pick up, that I will need to improve, is that while I did solve the player state classes being copied into a newly loaded window, the reverse isn't true yet. So that if you navigate to a new page, then start the player and then go back to a previously loaded page, the first window does not show the correct player state. Added this as an issue: https://github.com/netmix/radio-station-pro/issues/148

[gusaus]

@majick777 It looks like I reverted back to the older version of Radio Station PRO for my recent test. I updated again to the latest version and the line 99 warning is gone.

That said, the player is again loading and fading in every time you navigate to a different page. https://github.com/netmix/openproducer-platform/issues/44#issuecomment-904778639

If you navigate the site you'll see the playback is no longer continuous. https://radio-openproducer-platform.pantheonsite.io/

[majick777]

@gusaus I don't see Teleporter there at all? The script is not being loaded. I'm confused as to what settings might cause this, seems you have continuous player on, this should load Teleporter automatically... I can tell from the debug that teleporter.php file was found and loaded. This immediately enqueues the scripts via the wp_enqueue_scripts WordPress hook. At this point, why the script tag is not outputting on the page is a mystery Seems something is interfering with the enqueuing, but without deep debugging its hard to know what... got any rogue minification or caching plugins active?

[gusaus]

@majick777 As noted in https://github.com/netmix/openproducer-platform/issues/44#issuecomment-904778639 this behavior happened as soon as I updated from 2.4.1.3 to 2.4.1.4. I made no other changes in the settings.

Just to make sure I reinstalled 2.4.1.3 and reset to the default settings. I don't have any rogue minification or caching plugins active.

Here's a quick vid of me testing 2.4.1.3 (you'll see the line 99 warning) - at the latter part of the vid I refreshed my browser with 2.4.1.4 and the player is no longer continuous. https://monosnap.com/file/3JPjmYyaqzuImcLfhQ8on9HJZ9CFV1

@tonyzeoli Is https://radiostationdemo.com/ is running on 2.4.1.4? Looking at that now, the player seems to be reloading every time you navigate to a new page... so playback there is also 'not' continuous.

[majick777]

@gusaus Ach, no, it's my bad after all. Something was preventing Teleporter from loading. Now I'm confused as to why it was working on my end in all my testing. I can only figure I had a line locally which was not in the release, but I can't find that - it just worked for me the whole time. Until I tried uploading it fresh again on the demo site, and it failed, which led me to fixing it there and pulling that back locally. All very strange, but that is WP hooks sometimes... I will push 2.4.1.5 today with the fix.

[gusaus]

Glad we were able to catch it. I'll test the fix when it's available. Thanks!

[majick777]

@gusaus Okay you can check out Pro 2.4.1.5 now... And also Free 2.4.0.3b via Github.

[gusaus]

@majick777 Thanks! I updated both plugins which resolved that problem. Unfortunately, the original issue where the sidebar content loads under the body still remains. Currently, the sidebar should display on all posts and archives. https://radio-openproducer-platform.pantheonsite.io/

Are you seeing the same thing you described here? https://github.com/netmix/openproducer-platform/issues/44#issuecomment-904291439

That said, if you can't replicate the issue on https://radiostationdemo.com/, I'll just assume this is some strange thing with my particular setup.

I also set you up as admin if you'd like to check the settings.

Thanks

[gusaus]

@majick777 @tonyzeoli - so for the hell of it, I decided to install Radio Station PRO on another staging site. This one hosted on Bluehost instead of Pantheon. Amazingly all the issues reported here are gone...including the warnings mentioned here https://github.com/netmix/openproducer-platform/issues/44#issuecomment-904778639

First I tried Make (all layouts looked fine!) and then switched back to the Newspack child theme the client is using. The player did 'not' show up w/ AMP enabled... so I disabled it. That, in turn, threw off some formatting, but that would most likely be the case with any site using AMP. The player itself doesn't look right on MacOSS and Firefox. That might be a theme specific issue.

I can create issues on the above if you'd like.

Main questions here are -

1) how's it working for you? http://justjazz.tv/staging/8028/

2) Any idea why a host like Pantheon would be the cause of the issues reported? Might be something to test out on your end - you both have access to the site and the Pantheon environment https://radio-openproducer-platform.pantheonsite.io/ We'd need another Radio Station PRO license as I'm now testing w/ mine on this other site.

BTW my partners at Just Jazz could well be an early adopter of Radio Station PRO. Makes sense to keep testing/improving on their staging environment.

[tonyzeoli]

That’s interesting about Pantheon. Different hosts have different environments. I’ve installed on all out sites on WP Engine. Nine have these issues. I would out a ticket in with Pantheon first and ask them why rhis is happening. They aren’t known to be the best WordPress hosting company. They were Drupal forever and begrudgingly adopted WordPress. They have different methods than WP Engine has, so it could be something with them. I don’t know. So, best to ask them why we are not having problems with WP Engine but they seem to cause issues.

Also, the new demo URL is now demo.radiostation.pro. I’ve redirected the old URL and all traffic points to the new one now. Better for SEO with aggregate traffic to a primary domain. Amd better for branding purposes in thst domain.

On Fri, Aug 27, 2021 at 5:58 PM Gus Austin @.***> wrote:

@majick777 https://github.com/majick777 @tonyzeoli https://github.com/tonyzeoli - so for the hell of it, I decided to install Radio Station PRO on another staging site. This one hosted on Bluehost instead of Pantheon. Amazingly all the issues reported here are gone...including the warnings mentioned here OpenProducer/newspack-platform#10 (comment) https://github.com/netmix/openproducer-platform/issues/44#issuecomment-904778639

First I tried Make (all layouts looked fine!) and then switched back to the Newspack child theme the client is using. The player did 'not' show up w/ AMP enabled... so I disabled it. That, in turn, threw off some formatting, but that would most likely be the case with any site using AMP. The player itself doesn't look right on MacOSS and Firefox. That might be a theme specific issue.

I can create issues on the above if you'd like.

Main questions here are -

1.

how's it working for you? http://justjazz.tv/staging/8028/ 2.

Any idea why a host like Pantheon would be the cause of the issues reported? Might be something to test out on your end - you both have access to the site and the Pantheon environment https://radio-openproducer-platform.pantheonsite.io/ We'd need another Radio Station PRO license as I'm now testing w/ mine on this other site.

BTW my partners at Just Jazz could well be an early adopter of Radio Station PRO. Makes sense to keep testing/improving on their staging environment.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/netmix/openproducer-platform/issues/44#issuecomment-907497219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA65WO4WRMYETJGC7MTF6A3T7ADBZANCNFSM5CVAFLZQ .

-- Sent from Gmail Mobile

[majick777]

@gusaus Yes please do add separate issues for AMP compatibility and MacOSS/Firefox styling in the Pro repository so we can prioritize those. (I did notice a border around the volume slider, which is ugly. I think that is coming from the theme and so will remove that by adding border: none to it in the default player styling to begin with.)

I tested the player on Jazz site, and seems to be playing and transitioning fine for me. Maybe there are more specific conditions that need to be retested? The main issue for me is still as in this issue with the player classes not being reflected during backwards (and further with repeat navigation): https://github.com/netmix/radio-station-pro/issues/148

But if I can reproduce others (step by step as to what is clicked and in what order) then I can debug those more specifically too. The issue with Make body classes seems to have been resolved by the update... So I'm not sure what other issues you are meaning now as possibly relating to the Pantheon server setup (as that was the one that led us to believe that could be a problem, but it seems like it wasn't on that front, so possibly that was a false guess.)

[gusaus]

Thanks again @majick777.

Yes please do add separate issues for AMP compatibility and MacOSS/Firefox styling in the Pro repository so we can prioritize those.

What about creating issues in this repo for those specific to OpenProducer and Newspack (dependences and/or theme). It might be easier for you to replicate as you can already have admin access to this testing environment https://justjazz.tv/staging/8028/

I can also create issues like https://github.com/netmix/radio-station-pro/issues/153 in the Pro repository for anything 'not' OpenProducer or Newspack specific.

[tonyzeoli]

OpenProducer has its own repo now, so issues should be posted there fir the OpenProducer platform.

On Mon, Aug 30, 2021 at 6:03 PM Gus Austin @.***> wrote:

Thanks again @majick777 https://github.com/majick777.

Yes please do add separate issues for AMP compatibility and MacOSS/Firefox styling in the Pro repository so we can prioritize those.

What about creating issues in this repo for those specific to OpenProducer and Newspack (dependences and/or theme). It might be easier for you to replicate as you can already have admin access to this testing environment https://justjazz.tv/staging/8028/

I can also create issues like netmix/radio-station-pro#153 https://github.com/netmix/radio-station-pro/issues/153 in the Pro repository for anything 'not' OpenProducer or Newspack specific.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/netmix/openproducer-platform/issues/44#issuecomment-908732749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA65WOZYIRPK25G6DTRSMCLT7P52PANCNFSM5CVAFLZQ .

-- Sent from Gmail Mobile

[majick777]

@gusaus @tonyzeoli True I didn't think about that, on second look, the AMP compatibility is an OpenProducer issue. But display issues in browsers should be Radio Station Pro ones. eg. https://github.com/netmix/radio-station-pro/issues/152

[gusaus]

I created https://github.com/netmix/openproducer-platform/issues/45 and closed out the one in the Radio Station PRO repo.

[gusaus]

Closing this out as I haven't been able to replicate when 'not' testing on Pantheon.

[gusaus]

Reopening this as I'm testing the updated platform (now a 'radio' branch on our Newspack platform with Radio Station 2.4.0.8 + Radio Station PRO 2.4.1.8) and am still getting issues similar to https://github.com/OpenProducer/newspack-platform/issues/10#issuecomment-1083790931. Here are a couple screengrabs.

Newspack theme/multiple browsers/Pantheon development environment (https://radio-newspack.pantheonsite.io/)

Make theme/multiple browsers/local host

Here's the debugging info that appears on the screengrab (if you zoom in).

( ! ) Warning: count(): Parameter must be an array or an object that implements Countable in /Users/gusaustin/Local Sites/newspack/app/public/wp-content/plugins/radio-station-pro-premium/teleporter/teleporter.php on line 406

1 | 0.0002 | 412392 | {main}( ) | .../index.php:0 2 | 0.0003 | 412664 | require( '/Users/gusaustin/Local Sites/newspack/app/public/wp-blog-header.php' ) | .../index.php:17 3 | 0.4843 | 14347608 | require_once( '/Users/gusaustin/Local Sites/newspack/app/public/wp-includes/template-loader.php' ) | .../wp-blog-header.php:19 4 | 0.4885 | 14372048 | include( '/Users/gusaustin/Local Sites/newspack/app/public/wp-content/themes/make/page.php' ) | .../template-loader.php:106 5 | 0.4885 | 14372048 | get_header( ) | .../page.php:6 6 | 0.4887 | 14373648 | locate_template( ) | .../general-template.php:48 7 | 0.4887 | 14373760 | load_template( ) | .../template.php:716 8 | 0.4888 | 14382328 | require_once( '/Users/gusaustin/Local Sites/newspack/app/public/wp-content/themes/make/header.php' ) | .../template.php:770 9 | 0.4890 | 14382328 | wp_head( ) | .../header.php:9 10 | 0.4890 | 14382328 | do_action( ) | .../general-template.php:3042 11 | 0.4890 | 14382704 | WP_Hook->do_action( ) | .../plugin.php:474 12 | 0.4890 | 14382704 | WP_Hook->apply_filters( ) | .../class-wp-hook.php:331 13 | 0.4892 | 14384928 | wp_enqueue_scripts( ) | .../class-wp-hook.php:307 14 | 0.4892 | 14384928 | do_action( ) | .../script-loader.php:2115 15 | 0.4892 | 14385304 | WP_Hook->do_action( ) | .../plugin.php:474 16 | 0.4892 | 14385304 | WP_Hook->apply_filters( ) | .../class-wp-hook.php:331 17 | 0.5392 | 14681128 | teleporter_enqueue_scripts( ) | .../class-wp-hook.php:307 18 | 0.5395 | 14682488 | teleporter_localize_settings( ) | .../teleporter.php:366

Any ideas about what this could be?

[majick777]

@gusaus Thanks for this! I thought I had already managed to fix that one. For the life of me I can't get my head around why the current checks aren't enough... I opened an issue here for this and updated the Teleporter plugin to 1.0.2 for it: https://github.com/majick777/teleporter/issues/6 ...and added that to the develop branch of Radio Station Pro. If you can test out with that version, hopefully this issue it finally resolved.

[gusaus]

@majick777 Great to hear from you - and thanks for looking into this!

I'm testing dev on the same environments and it looks like I'm getting another message...

Newspack theme/multiple browsers/Pantheon development environment (https://radio-newspack.pantheonsite.io/)

Make theme/multiple browsers/local host

Here's the debugging info that appears on the screengrab (if you zoom in)...	Time	Memory	Function	Location
1	0.0003	412296	{main}( )	.../index.php:0
2	0.0004	412568	require( '/Users/gusaustin/Local Sites/newspack/app/public/wp-blog-header.php' )	.../index.php:17
3	0.4158	14349024	require_once( '/Users/gusaustin/Local Sites/newspack/app/public/wp-includes/template-loader.php' )	.../wp-blog-header.php:19
4	0.4220	14373464	include( '/Users/gusaustin/Local Sites/newspack/app/public/wp-content/themes/make/page.php' )	.../template-loader.php:106
5	0.4220	14373464	get_header( )	.../page.php:6
6	0.4222	14375064	locate_template( )	.../general-template.php:48
7	0.4222	14375176	load_template( )	.../template.php:716
8	0.4222	14383744	require_once( '/Users/gusaustin/Local Sites/newspack/app/public/wp-content/themes/make/header.php' )	.../template.php:770
9	0.4225	14383744	wp_head( )	.../header.php:9
10	0.4225	14383744	do_action( )	.../general-template.php:3042
11	0.4225	14384120	WP_Hook->do_action( )	.../plugin.php:474
12	0.4225	14384120	WP_Hook->apply_filters( )	.../class-wp-hook.php:331
13	0.4226	14386344	wp_enqueue_scripts( )	.../class-wp-hook.php:307
14	0.4226	14386344	do_action( )	.../script-loader.php:2115
15	0.4226	14386720	WP_Hook->do_action( )	.../plugin.php:474
16	0.4226	14386720	WP_Hook->apply_filters( )	.../class-wp-hook.php:331
17	0.4418	14470208	teleporter_enqueue_scripts( )	.../class-wp-hook.php:307
18	0.4421	14471568	teleporter_localize_settings( )	.../teleporter.php:366
19	0.4423	14474576	apply_filters( )	.../teleporter.php:400
20	0.4423	14474976	WP_Hook->apply_filters( )	.../plugin.php:189

Hope that helps. I'll be happy to test further tomorrow. Thanks!

[majick777]

@gusaus Erk yeah whoops, that was added for a smaller Teleporter issue https://github.com/majick777/teleporter/issues/3 Just added a missing prefix to the function name and pushed it back to Radio Station Pro develop, that should fix that. Thanks again for picking that up! I also just made a slight fix to RSP so that if you are playing and transition to a new page via Teleporter, the Show info AND track meta display (if any) appear when loaded (rather than waiting for the metadata to reload.) :-)

[gusaus]

@majick777 Testing now and I'm getting a slightly different warning...

Newspack theme/multiple browsers/Pantheon development environment (https://radio-newspack.pantheonsite.io/)

Make theme/multiple browsers/local host

Here's the debugging info that appears on the screengrab (if you zoom in)...

Warning: count(): Parameter must be an array or an object that implements Countable in /Users/gusaustin/Local Sites/newspack/app/public/wp-content/plugins/radio-station-pro-premium/teleporter/teleporter.php on line 417

Time	Memory	Function	Location
1	0.0004	412328	{main}( )	.../index.php:0
2	0.0004	412600	require( '/Users/gusaustin/Local Sites/newspack/app/public/wp-blog-header.php' )	.../index.php:17
3	0.4595	14349064	require_once( '/Users/gusaustin/Local Sites/newspack/app/public/wp-includes/template-loader.php' )	.../wp-blog-header.php:19
4	0.4652	14373504	include( '/Users/gusaustin/Local Sites/newspack/app/public/wp-content/themes/make/page.php' )	.../template-loader.php:106
5	0.4652	14373504	get_header( )	.../page.php:6
6	0.4655	14375104	locate_template( )	.../general-template.php:48
7	0.4655	14375216	load_template( )	.../template.php:716
8	0.4662	14383784	require_once( '/Users/gusaustin/Local Sites/newspack/app/public/wp-content/themes/make/header.php' )	.../template.php:770
9	0.4664	14383784	wp_head( )	.../header.php:9
10	0.4664	14383784	do_action( )	.../general-template.php:3042
11	0.4664	14384160	WP_Hook->do_action( )	.../plugin.php:474
12	0.4664	14384160	WP_Hook->apply_filters( )	.../class-wp-hook.php:331
13	0.4666	14386384	wp_enqueue_scripts( )	.../class-wp-hook.php:307
14	0.4666	14386384	do_action( )	.../script-loader.php:2115
15	0.4666	14386760	WP_Hook->do_action( )	.../plugin.php:474
16	0.4666	14386760	WP_Hook->apply_filters( )	.../class-wp-hook.php:331
17	0.5116	14682584	teleporter_enqueue_scripts( )	.../class-wp-hook.php:307
18	0.5119	14683944	teleporter_localize_settings( )	.../teleporter.php:366

I should be around to test and help troubleshoot today.

[gusaus]

@tonyzeoli @majick777 I'm confused (as usual :confused:) though... as it looks like this is 'not' a Pantheon specific issue (as we previously thought it was), is it specific to Newspack? Assuming this would have been reported by others if it was a common problem with Radio Station PRO.

[majick777]

@gusaus What version of PHP version are you using? This might show in PHP7.x or only in 8. As I said, I have seen this error before and thought I'd fixed it already.

It's a warning rather than an error, so won't prevent loading and unless someone has debugging mode turned on, they won't see it anyway. On that note, if you are displaying rather than logging errors, it's worth being aware that this can cause a cascade into other unforeseen errors with "headers already sent" and can affect redirects and cookies etc. Better practice is to use a proper debugger, or an error handler class and output the errors on shutdown. (I've written an error handler class for this if you'd like to try it.)

Finally, I am staring at this code as I have a few times already, scratching my head and it dawned on me that: ( count( $ignore_classes > 0 ) ) is wrong after all. ( count( $ignore_classes ) > 0 ) is what is should be. Sooo, just a simple bracket misplacement typo after all that. facepalm

Try it now I've pushed another update to fix this and another improvement to the player page transitions.

[gusaus]

@majick777 It looks like the last fix got rid of the warnings!! This is great progress, thanks!!

That said, we might still be experiencing some of the layout/performance issues as noted in the issue description https://github.com/OpenProducer/newspack-platform/issues/10.

Here are some notes/links pertaining to the current 'Newspack' development environment (by the way, I set you and @tonyzeoli as admins) - https://radio-newspack.pantheonsite.io/

The development environment is powered by this repo/branch - https://github.com/OpenProducer/newspack-platform/tree/radio

The PHP version is 7.4

Here's a screengrab of the current Sitewide Bar Player settings

I was going to upload a video capturing my experience browsing the current environment but I'm having issues with Monosnap...

....generally speaking, the sound takes awhile to come on after hitting play. The transitions from page to page seems a bit laggy (could be my settings?). Some of the layouts are a bit off... those could well be issues related to Newspack and/or the particular Newspack theme and not directly related to the player.

Again, you both have admin access - maybe you can test out yourself and share your thoughts.

Thanks!

[gusaus]

So I updated to the latest versions of Radio Station (Version 2.4.0.9) + Radio Station PRO (Version 2.4.1.9) and the warnings reported in this issue are gone!

That said, there are issues that most likely need to be addressed (see my previous comment) before Newspack adds to their list of approved third-party plugins (see https://newspack.pub/support/plugins/). The paid beta offering we're discussing should provide us with the resources needed for Newspack to recommend along with an opportunity to collaborate/partner with their team. Especially if someone from the Netmix/Radio Station PRO is able to commit to the PM role.

[gusaus]

Closing as it we're no longer including or supporting Radio Station PRO in this repo.