Posts associated with a show do not display correctly on the show page

[gusaus]

Describe the bug Posts associated with a show do not display correctly on the show page

To Reproduce Steps to reproduce the behavior:

1. Go to any post on https://radio-openproducer-platform.pantheonsite.io/ and relate it to a show in the right sidebar
2. Scroll down and click the link to the associated show page
3. Scroll down to where the post is displayed
4. You'll see something like https://radio-openproducer-platform.pantheonsite.io/show/show-1/#show-posts https://radio-openproducer-platform.pantheonsite.io/show/show-2/#show-posts

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: macOS
• Browser Chrome, Firefox, etc.

Additional context This could well be another conflict with Newspack and/or any of it's dependencies (https://newspack.blog/support/plugins/#required-plugins). I disabled most of the them and the problem remained. I also switched to a non-Newspack theme (Make).

If this sounds like a non-Newspack related issue, I'll post in the Radio Station issue queue.

[gusaus]

@tonyzeoli @majick777 Looks like this is another case where a Newspack requirement is the root cause of the weirdness. The problem seems to be that AMP, in the default 'Standard' setting when enabled with Newspack, is making assumptions that all plugins and themes are compatible. Radio Station plugin is not.

Assuming y'all know much more about how it works https://amp-wp.org/, I'll just say then when you have AMP in 'Reader' mode and uncheck all content types that ship with Radio Station, the display issues are resolved.

So on this instance, the formatting looks as it should (right)? https://live-openproducer-platform.pantheonsite.io/show/show-1/ https://live-openproducer-platform.pantheonsite.io/show/show-2/

Unfortunately, it looks like switching the AMP setting will not remove the formatting after the fact -
https://radio-openproducer-platform.pantheonsite.io/show/show-1/ https://radio-openproducer-platform.pantheonsite.io/show/show-2/

You have access to these instances, so don't hesitate to log in and dig around.

[tonyzeoli]

Hmmm...

We haven't yet considered AMP and haven't discussed supporting AMP yet. If the Read mode falls back and displays the page properly, then that's a good thing. I believe AMP renders the content of your page in the AMP'd environment, which is mobile display always. So, we'll have to think about how AMP responds to our custom post type for Shows and in the future for Episodes and Segments.

On Fri, May 1, 2020 at 7:29 PM Gus Austin notifications@github.com wrote:

@tonyzeoli https://github.com/tonyzeoli @majick777 https://github.com/majick777 Looks like this is another case where a Newspack requirement https://newspack.blog/support/plugins/#required-plugins is the root cause of the weirdness. The problem seems to be that AMP, in the default 'Standard' setting when enabled with Newspack, is making assumptions that all plugins and themes are compatible. Radio Station plugin is not.

Assuming y'all know much more about how it works https://amp-wp.org/, I'll just say then when you have AMP in 'Reader' mode and uncheck all content types that ship with Radio Station, the display issues are resolved.

[image: e8c0a21ef0e0f5101a0d9e590435203ca7bf96af 2020-05-01 16-09-19] https://user-images.githubusercontent.com/113996/80847811-e4b35e80-8bc5-11ea-89c1-2923b8554605.png

So on this instance, the formatting looks as it should (right)? https://live-openproducer-platform.pantheonsite.io/show/show-1/ https://live-openproducer-platform.pantheonsite.io/show/show-2/

Unfortunately, it looks like switching the AMP setting will not remove the formatting after the fact - https://radio-openproducer-platform.pantheonsite.io/show/show-1/ https://radio-openproducer-platform.pantheonsite.io/show/show-2/

You have access to these instance, so don't hesitate to log in and dig around.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <OpenProducer/newspack-platform#16>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA65WO5DXTCKYQH2OPWVDUTRPNLOZANCNFSM4MWLPS6Q .

[gusaus]

So, we'll have to think about how AMP responds to our custom post type for Shows and in the future for Episodes and Segments.

I don't know what it would take to make Radio Station AMP-ready, but it probably would help with adoption. https://amp-wp.org/ecosystem/

Probably would make it more likely for Newspack to recommend as I believe AMP compatibility is one of their main requirements https://newspack.blog/support/plugins/#recommended-plugins

That said, I'll close this down since there is a workaround that we just need to document.

[tonyzeoli]

Well, according to the consultant I spoke to, they’re not where near even thinking about Radio as a format they are going to support and that leaves us to be far from recommended.

However, AMP support should be on our list of baked in free features and I’ll talk to Tiny about it.

On Mon, May 4, 2020 at 3:45 AM Gus Austin notifications@github.com wrote:

Closed OpenProducer/newspack-platform#16 <OpenProducer/newspack-platform#16>.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <OpenProducer/newspack-platform#16>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA65WO54K67WVGA4KJEFGV3RPZXAHANCNFSM4MWLPS6Q .

-- Sent from Gmail Mobile

[gusaus]

they’re not where near even thinking about Radio as a format they are going to support and that leaves us to be far from recommended.

I bet they might recommend Radio Station if a lot of stations and podcasters were using their platform. We're one task away from making that happen - https://github.com/OpenProducer/community/issues/8#issue-605040623