search

OpenQuickJS / quickjs

A community-driven QuickJS fork. Issues and Pull Requests are welcome.
https://openquickjs.org
Other
20 stars 3 forks source link

QuickJS build failed - Ubuntu20 : trying to find `rustc` #10

Open krazykoder opened 11 months ago

krazykoder commented 11 months ago

Trying to build quickjs on ubuntu20. Getting the following error on two different ubuntu instances.

cmake and ninja install was successful. sudo apt install cmake ninja-build # Ubuntu

quickjs > bash scripts/build.sh # build quickjs qjs qjsc etc.                      ~/code/js/quickjs:@sparta 11:12
+ rm -rf build bin lib
+ mkdir build
+ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -B build -S .
-- The C compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at build/_deps/corrosion-src/cmake/FindRust.cmake:21 (message):
  `rustc` not found in PATH or `/home/towshif/.cargo/bin`.

  Hint: Check if `rustc` is in PATH or manually specify the location by
  setting `Rust_COMPILER` to the path to `rustc`.
Call Stack (most recent call first):
  build/_deps/corrosion-src/cmake/FindRust.cmake:259 (_findrust_failed)
  build/_deps/corrosion-src/cmake/Corrosion.cmake:57 (find_package)
  build/_deps/corrosion-src/CMakeLists.txt:68 (include)

-- Configuring incomplete, errors occurred!
See also "/home/towshif/code/js/quickjs/build/CMakeFiles/CMakeOutput.log".
+ cmake --build ./build --target qjs run-test262 -j 8
ninja: error: loading 'build.ninja': No such file or directory
shiqimei commented 11 months ago

CMake Error at build/_deps/corrosion-src/cmake/FindRust.cmake:21 (message): rustc not found in PATH or /home/towshif/.cargo/bin.

The latest version depends on rust, please make sure rust installed.

https://www.rust-lang.org/learn/get-started

krazykoder commented 11 months ago

A little confused here. I compiled the original repo https://github.com/bellard/quickjs with basic cmake and gcc. But here, the compiler detection is not using the existing compiler. Rather I should installed another compiler rustc. Is that what you recommend. 

-- The C compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
krazykoder commented 11 months ago

Just saw your prior commits. You have progressively moved to rustc for maintainability. Understood thanks.