search

OpenRA / OpenRA

Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.
https://www.openra.net
GNU General Public License v3.0
14.68k stars 2.68k forks source link

No icon for OpenRA app in Windows taskbar #14174

Closed netnazgul closed 6 years ago

netnazgul commented 7 years ago

Issue is reproduced on both Windows 10 and Windows 8.1 unknown image

However, as @pchote stated, it does show in his Windows configuration. f4ote30

pchote commented 7 years ago

This is the code responsible for setting the icon:

https://github.com/OpenRA/OpenRA/blob/f2b5040d309818d817fa25a3e81e0d75ef0b8ca2/packaging/windows/WindowsLauncher.cs.in#L96-L106

It would be helpful if somebody who can reproduce the problem is able to debug this and report what is going wrong.

reaperrr commented 7 years ago

Seems to work on Win7, so 8+ must be doing something different.

MustaphaTR commented 7 years ago

I'm on Win7, it doesn't work for me.

netnazgul commented 7 years ago

Somehow today the icon finally shows up for me... Strange bug

netnazgul commented 6 years ago

upd: Still happening sporadically. More times there is a generic icon, only seen the correct icon 2-3 times.

dragunoff commented 6 years ago

This is also the case on my Windows 7 machine - the taskbar icon is a generic one.

penev92 commented 6 years ago

Sounds serious enough, we should try to get it fixed for the next release.

Unit158 commented 6 years ago

This occurs on my compiled version but not my installed release.

pchote commented 6 years ago

@Unit158: Just to clarify, are you manually compiling and running the RedAlert.exe etc, or just running through your IDE? Not showing an icon when running OpenRA.Game.exe directly is deliberate, and different to the issue here (which is that the launchers are sporadically failing to set the icon of the remote process).

Unit158 commented 6 years ago

Ah, I suppose I'm running OpenRA.Game.exe directly (when compiling) in that case :)

pchote commented 6 years ago

There is no way to fix this without a repro case, so removing from the milestone.

penev92 commented 6 years ago

Since I now have a PR ready for this I think we should still prioritize this for a playtest.

netnazgul commented 6 years ago

@penev92 if you point me to a buildable bleed I can download I can test it on my machine

pchote commented 6 years ago

@netnazgul: The launchers can't be built on windows, so here is an installer: https://www.dropbox.com/s/cbgp6kk9nqmheo8/OpenRA-packagetest-20171129.exe?dl=0