OpenRA / OpenRA

Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.
https://www.openra.net
GNU General Public License v3.0
14.68k stars 2.68k forks source link

Option to rescan sound devices in settings #17651

Open netnazgul opened 4 years ago

netnazgul commented 4 years ago

OpenRA (as far as I'm aware) only scans for available sound outputs once during app launch. If sound configuration is changed (devices removed/added, OS sound output changed), OpenRA loses sound until restarted.

netnazgul commented 4 years ago

Discord log related to the issue

The Navigator (Bain): Am I the only person that has huge sound issue with openRA

The Navigator (Bain): for exmaple

The Navigator (Bain): if my wireless headphones lose connection for a second

The Navigator (Bain): I have to restart the game to get game sound back

The Navigator (Bain): and if the game does not connect to the device i'm using, for when reboting it will crash

The Navigator (Bain): I've had this issue for a long time, on a laptop and on a pc.

The Navigator (Bain): using different headphones and earphones had still the same issue .

penev92: the first one is simple - when your headphones lose connection the OS switches the output device, but OpenRA doesn't register that and keeps trying to use the old one

penev92: the second one I didn't understand

The Navigator (Bain): no i'm only on one output

The Navigator (Bain): i can't get sound at all

The Navigator (Bain): perhaps I should check this again when it happend, but as far as i'm aware, it won't go back to the headphones

WhoCares: if I plug/unplug my headphone or, as @penev92 stated, make a change in the output device, openra loses sound and i have to restart the game. always has been.

netnazgul: afair OpenRA only scans for sound devices once on launch. I also had it very annoying to not picking up/not being able to change sound input correctly when I plugged in/out my USB headphones.

pchote commented 4 years ago

Somewhat related to #12300, which we fixed in the hotfix. Fixing this goes well with the theme of the settings menu overhaul, so I'll take this on for Next.

netnazgul commented 4 years ago

Yes, Bain's is a corner case when the only sound output is [briefly] disconnected during OpenRA operation, I didn't think it warranted a separate issue raised.

pchote commented 4 years ago

It turns out that this is not currently feasible without a serious rewrite of the sound code. The current setup can't change devices on the fly - only on game start.