Open MlemandPurrs opened 1 year ago
From the discussion on Discord: Ideally we pause AttackBase while the power is charging. Unfortunately the power starts recharging before the weapon fires so this is not doable until the support power code is rewritten to account for that.
From the discussion on Discord I think it became apparent that there is no "ideally". I'll leave my finishing statement from there here as well:
IMO it's not completely off the table to cut our loses and decide that SupportPower code and attack code should not touch and just have the EMPCannon have its own hardcoded logic like all other powers so it doesn't use regular attacking ... aaaand then we can focus on having a semi-good mechanic for SP/SPInstance/SPManager knowing when a SP activation has started (successfully) and when it has ended
Also not mixing those two issues is important:
https://github.com/OpenRA/OpenRA/pull/21133 was reverted.
In Tiberian Sun mod, build the E.M. Pulse Cannon, ensure you have positive Power, select it now CTRL click on ground weapon fires via Force Attack, bypassing it's attached AttackOrderPower.
Expectation: it should only able to fire through the AttackOrderPower when its ready.