search

OpenRA / OpenRA

Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.
https://www.openra.net
GNU General Public License v3.0
14.52k stars 2.65k forks source link

Global chat: user bin tooltips should show IP and country. #9685

Closed pchote closed 6 years ago

GraionDilach commented 8 years ago

Why IP? That worries me a bit tbh, we shouldn't release their IP to everyone.

pchote commented 8 years ago

To prevent trolls and nick-stealers. We already expose the IP for all players in the lobby in the same way, and this info is available for anyone using a regular IRC client.

GraionDilach commented 8 years ago

This is a huge privacy concern still and I don't know any games which does this as well - they only used IPs for direct IP and never revealed others' on a lobby screen. I understand that this is kinda "simpler" than running a registration system on the IRC protocol, but this sounds quite abusive to me in the long run.

Mailaender commented 8 years ago

We could only show the vhost like openra-66A92FDB.range213-122.btcentralplus.com which is unique and gives away enough information to verify someone's approximate origin.

pchote commented 8 years ago

They can still be mapped back to IP, and are monster strings to display in the UI.

ghost commented 7 years ago

@pchote Doing this would be a huge security and privacy concern, OpenRA already shows all connected IP's to clients on the server chat/setup window which I strongly object to and can be abused very easily. You could have randomly generated IDs for example.

A Client requests to join the Server. The Server generates a random 12 number string for the Client. The Client joins and the Server sends the ply.rid with it.

I'm sure that this is possible in pretty much any language & will solve the IP identifier/nick stealer issue.

pchote commented 6 years ago

The global chat feature has been removed.