search

OpenRA / OpenRAModSDK

Software Development Kit for building your own games using the OpenRA engine.
http://www.openra.net
GNU General Public License v3.0
121 stars 68 forks source link

Update .editorconfig to match the new one from the OpenRA repository #194

Closed oldnaari closed 11 months ago

oldnaari commented 11 months ago

Recently my mod began to refuse to pass the CI. Copying the .editorconfig from https://github.com/OpenRA/OpenRA/blob/bleed/.editorconfig was an important component for fixing that. So here it comes )

penev92 commented 11 months ago

Hi there and thanks for the PR. I already had a commit for the .editorconfig file in #193, but I don't mind dropping that in favor of this PR. However, you seem to have copied the file from OpenRA's bleed branch, which is about 10 commits ahead of release-20231010. Currently the ModSDK has a single master branch that targets OpenRA releases and very rarely gets patches inbetween. I'd say you should either take the release version of the file and we merge this before #193 or you wait for that to get merged and then this can be merged as an inbetween-releases patch.

oldnaari commented 11 months ago

Hello @penev92. My bad didn't see the pull request. I will better wait for https://github.com/OpenRA/OpenRAModSDK/pull/193 in that case

abcdefg30 commented 11 months ago

193 was merged so you can rebase this.

oldnaari commented 11 months ago

I think we can close this pull request for now. What I wanted to achieve here is done by #193 in a more thoughtful manner.