search

OpenRA / TiberianDawnHD

Multiplayer compatible OpenRA mod that uses Command & Conquer: Remastered assets
GNU General Public License v3.0
36 stars 4 forks source link

Origin / EA App content installation is failing #26

Closed penev92 closed 1 year ago

penev92 commented 1 year ago

Reports have been coming in over the past few months, which roughly coincided with the launch of the new EA App that replaced Origin, so we blamed that. Turns out it was https://github.com/OpenRA/OpenRA/commit/7188f88ba1ef66a8379b39784cb6e29772127fc4 that broke content source detection because mod.yaml does not define IDFiles:

RemasterModContent:
    RemasterDataMount: data
    Sources:
        steam:
            Type: Steam
                AppId: 1213210
        origin:
            Type: RegistryDirectory
            RegistryPrefixes: HKEY_LOCAL_MACHINE\Software\, HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\
            RegistryKey: Petroglyph\CnCRemastered
            RegistryValue: Install Dir

Since that commit several SourceResolvers, including RegistryDirectorySourceResolver, which is what the origin source uses, require IDFiles.

IceReaper commented 1 year ago

Sound like https://github.com/OpenRA/OpenRA/pull/20776 to me ;)

IceReaper commented 1 year ago

As my linked PR is merged, this needs an IDFiles entry. While it will no longer crash when using https://github.com/OpenRA/OpenRA/pull/20791 it will run into another problem mentioned in the other PR: If you delete the game folder, the steam app manifest file, or the ea registry entry will still be present, hence resolving. I highly suggest to add IDFiles to this installer file for this case!

pchote commented 1 year ago

Fixed in the new playtest build.