search

OpenRA / d2

A d2 mod for OpenRA
GNU General Public License v3.0
57 stars 20 forks source link

Update mod to release-20230225 #222

Closed penev92 closed 1 year ago

penev92 commented 1 year ago

It is finally time to update the mod to OpenRA's release 20230225.

To make this as simple as possible for everyone involved I tried to follow the commit structure and all the ideas behind https://github.com/OpenRA/ra2/pull/806.

To ease the review as much as possible this uses the latest ModSDK version from https://github.com/OpenRA/OpenRAModSDK/pull/183, the same as TDHD's release-20230225 uses.

This is still WIP, but I'm opening it so hopefully the reviewing process can gradually get going and also so someone else doesn't waste effort doing the same work at the same time.

Supersedes #201. Closes #212.

penev92 commented 1 year ago

Added a bunch of fixes, updates and polish. This should now be good to go.

penev92 commented 1 year ago

Ok, apparently I was wrong - this was not ready. Both make check and make test were going nuts and I hadn't noticed. So I added a bunch of code and yaml fixes, some fixing issues from many years ago. It should be good to go now.

penev92 commented 1 year ago

@evgeniysergeev are you able to review? I'm most interested in some things from commit Manual mod updates PART 9, like the Devastator overloading.

evgeniysergeev commented 1 year ago

@evgeniysergeev are you able to review? I'm most interested in some things from commit Manual mod updates PART 9, like the Devastator overloading.

Sorry for late answer. I'm trying to review now.

evgeniysergeev commented 1 year ago

@penev92 , I think this is great PR. All this comments above can be fixed later, and changes can be merged. But if you have a time, can you take a look at comments?

evgeniysergeev commented 1 year ago

@evgeniysergeev are you able to review? I'm most interested in some things from commit Manual mod updates PART 9, like the Devastator overloading.

Don't know what should happen when Devastator is overloaded. Is this overloading exists in original game? :-)