search

OpenRA / openrauseraccounts

Connect phpBB forum accounts to OpenRA installations
https://forum.openra.net/ucp.php?i=232
GNU General Public License v2.0
3 stars 3 forks source link

General review comments #34

Closed pchote closed 6 years ago

pchote commented 6 years ago

/controller/main.php: Return error messages as a response instead of echoing and exiting.

/core/core.php: get_badge_sql function shares no code between the userid / fingerprint cases, and will behave badly if neither are given. Split this into two different functions instead.

/ucp/useraccounts_module.php: empty($markedbadges) ? $delete_sql = '' : ' AND ' . $this->db->sql_in_set('badge_id', $markedbadges, true); looks bogus. Did you mean delete_sql = empty($markedbadges) ? '' : ' AND ' ...`? If not, write this as a proper if statement.

/language/en/*.php: Why do these filenames end with an underscore?

ghost commented 6 years ago

These points have been addressed in the referenced pr.