search

OpenRA / openrauseraccounts

Connect phpBB forum accounts to OpenRA installations
https://forum.openra.net/ucp.php?i=232
GNU General Public License v2.0
3 stars 3 forks source link

Rename modules #40

Closed ghost closed 5 years ago

ghost commented 5 years ago

To make the naming consistent for better use with language keys.

I noticed that changing settings, types or badges in the module info like below caused problems with the migration. This is the reason of the ACP_BADGES_BADGES name, which would have included "manage" else. This is important to consider when naming new modes.

``` php class badges_info { public function module() { return array( 'filename' => '\openra\openrauseraccounts\acp\badges_module', 'title' => 'ACP_BADGES', 'modes' => array( 'settings' => array( 'title' => 'ACP_BADGES_SETTINGS', 'auth' => 'ext_openra/openrauseraccounts && acl_a_board', 'cat' => array('ACP_BADGES') ), 'types' => array( 'title' => 'ACP_BADGES_TYPES', 'auth' => 'ext_openra/openrauseraccounts && acl_a_board', 'cat' => array('ACP_BADGES') ), 'badges' => array( 'title' => 'ACP_BADGES_BADGES', 'auth' => 'ext_openra/openrauseraccounts && acl_a_board', 'cat' => array('ACP_BADGES') ```

I have tested that this works when updating from 1.0.1, as well as for a fresh extension installation. I also tested that after the update/installation of 1.0.2 disabling the extension and deletion of the extension data works.

ghost commented 5 years ago

I don't want to work for some people who use this and removed myself from collaborators, as I'm no longer interested in contributing. I apologize that I haven't been able to maintain this project properly and fix some of the low quality code earlier. IMO the project should be archived and the accounts function deactivated as long as it is unmaintained.