OpenRA / ra2

A Red Alert 2 mod for the OpenRA game engine
GNU General Public License v3.0
970 stars 160 forks source link

Added more landing pads to the Airforce Command Center #735

Closed Mailaender closed 1 year ago

Mailaender commented 4 years ago

Closes https://github.com/OpenRA/ra2/issues/87.

sorcerer86pt commented 4 years ago

Ok, tested this commit. Some changes need to be done. As you can see in this video:

multiple airfields (see behavior after 30s mark)

When multiple airfields exists, the airplanes sometimes enter in loop trying to find a slot, when another one is open (mostly when building new planes, when coming back from bombing mission, they find the slot correctly)

An possible fix is at build time, find a open slot in all airfields that the player controls and then deploy that plane there.

pgwipeout commented 4 years ago

Your video is not accessible unfortunately.

sorcerer86pt commented 4 years ago

Ok, should be gdrive permissions. I will fix that

A quarta, 24/06/2020, 16:20, Peter Geis notifications@github.com escreveu:

Your video is not accessible unfortunately.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenRA/ra2/pull/735#issuecomment-648887157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2N4ZYGJFGKAMBIUI73JXLRYIKVRANCNFSM4OA3NARQ .

sorcerer86pt commented 4 years ago

Try now. Fixed the permissions

Mailaender commented 4 years ago

An possible fix is at build time, find a open slot in all airfields that the player controls and then deploy that plane there.

Probably not possible with the way this hack works. Only 25% of the pads is constructing aircraft, the others are just for rearming.

yaaaaa commented 4 years ago

May be it needs to spawn/build the plane right on free slot, and without flying/jumping after build?

sorcerer86pt commented 4 years ago

I approve of that.

A quarta, 24/06/2020, 19:54, yaaaaa notifications@github.com escreveu:

May be it needs to spawn/build the plane right on free slot, and without flying/jumping after build?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenRA/ra2/pull/735#issuecomment-649004190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2N4Z4ERGQFPVY6BREHGB3RYJDXTANCNFSM4OA3NARQ .

MustaphaTR commented 4 years ago

Also from the video @sorcerer86pt sent looks like planes land facing 0, they should face 224. https://github.com/MustaphaTR/Romanovs-Vengeance/commit/cc69debf2138312526bcd7c59110544e2a44017b

Mailaender commented 4 years ago

Changed the landing facing and added production capabilities to the pads. I don't know why TakeOffOnCreation: false is ignored. We have a ticket for that #683.

phrohdoh commented 4 years ago

SpawnNeighboringActors from a modding perspective (given the information this PR as-is makes available to modders) seems awfully similar to FreeActor, so I believe differentiating via docs/name would be beneficial.

Mailaender commented 4 years ago

Updated and fixed an issue where selling the aircraft command would not remove the additional pads.

Mailaender commented 3 years ago

Rebased and updated.

MustaphaTR commented 1 year ago

Needs rebase.

abcdefg30 commented 1 year ago

Tbh I'm not sure if this PR is necessary. If this repository seems unmaintained to people, I don't think there is a reason to add this workaround, or is there? I.e. since we're not in a rush we can wait for docking to work like we need.