OpenRA / ra2

A Red Alert 2 mod for the OpenRA game engine
GNU General Public License v3.0
977 stars 161 forks source link

Update engine version to release-20200503. #738

Closed MustaphaTR closed 3 years ago

abcdefg30 commented 4 years ago

Travis is also reporting errors.

MustaphaTR commented 4 years ago

Updated. Travis just failed to download Eluant for some reason, restarting it fixed the check.

phrohdoh commented 4 years ago

Any idea why mods/ra2/uibits/musicplayer.png's file size increased substantially?

abcdefg30 commented 4 years ago

Any idea why mods/ra2/uibits/musicplayer.png's file size increased substantially?

MustaphaTR commented 4 years ago

No idea. I just copy-pasted it from RV, which iirc copy-pasted there from RA when i was doing the engine update there.

Mailaender commented 4 years ago

I don't think this is any real problem, but here you go:

pngcrush musicplayer.png 
  Recompressing IDAT chunks in musicplayer.png
   Total length of data found in critical chunks            =       642
pngcrush: iCCP: known incorrect sRGB profile
   Best pngcrush method        =   4 (ws 15 fm 0 zl 9 zs 1) =       630
CPU time decode 0.000701, encode 0.006188, other 0.001267, total 0.008675 sec

musicplayer.png

MustaphaTR commented 4 years ago

Updated.

MustaphaTR commented 3 years ago

New playtest is coming, but this is still sitting here. Could somebody review this?

Mailaender commented 3 years ago

This suffers from https://github.com/MustaphaTR/Romanovs-Vengeance/issues/46 when using high DPI which can be fixed by removing https://github.com/OpenRA/ra2/blob/bdde553cd57873ff26e30f3e1f8b8c7f139078bc/mods/ra2/chrome/ingame-player.yaml#L490-L499

MustaphaTR commented 3 years ago

Updated.

Mailaender commented 3 years ago

See also https://github.com/MustaphaTR/ra2/pull/5.

MustaphaTR commented 3 years ago

Updated.