search

OpenRA / ra2

A Red Alert 2 mod for the OpenRA game engine
GNU General Public License v3.0
965 stars 158 forks source link

Set airborne condition for jumper sequences #792

Open mfzl opened 2 years ago

mfzl commented 2 years ago

There's already a PR https://github.com/OpenRA/ra2/pull/786 for fly sequence, but that doesn't completely fix the problem as I get the following after the fix.

Another option is to define these sequences for spy, but then it looks really weird and it's a dead give-away.

OpenRA engine version release-20210321
Red Alert 2 mod version {DEV_VERSION}
on map 8bdba6d3de9fbe330ac0a61db834317952ddf7cd (Dustbowl by Westwood Studios).
Date: 2022-05-01 00:05:52Z
Operating System: Linux (Unix 5.17.5.1)
Runtime Version: Mono 6.12.0 (makepkg/ed0788bf61f Sun Apr 24 04:25:18 PM UTC 2022) CLR 4.0.30319.42000
Exception of type `System.InvalidOperationException`: Unit `spy` does not have a sequence named `idle-air`
  at OpenRA.Graphics.SequenceProvider.GetSequence (System.String unitName, System.String sequenceName) [0x0005d] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Graphics/SequenceProvider.cs:78 
  at OpenRA.Graphics.Animation.GetSequence (System.String sequenceName) [0x00000] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Graphics/Animation.cs:234 
  at OpenRA.Graphics.Animation.PlaySequence (System.String sequenceName) [0x00000] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Graphics/Animation.cs:115 
  at OpenRA.Graphics.Animation.PlayThen (System.String sequenceName, System.Action after) [0x00022] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Graphics/Animation.cs:149 
  at OpenRA.Mods.Common.Traits.Render.WithInfantryBody.OpenRA.Traits.INotifyIdle.TickIdle (OpenRA.Actor self) [0x000ae] in /home/fazal/packages/ra2/engine/OpenRA.Mods.Common/Traits/Render/WithInfantryBody.cs:212 
  at OpenRA.Actor.Tick () [0x0006e] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Actor.cs:282 
  at OpenRA.World.Tick () [0x00144] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/World.cs:437 
  at OpenRA.Game.InnerLogicTick (OpenRA.Network.OrderManager orderManager) [0x001bc] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Game.cs:620 
  at OpenRA.Game.LogicTick () [0x0003e] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Game.cs:646 
  at OpenRA.Game.Loop () [0x000f1] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Game.cs:811 
  at OpenRA.Game.Run () [0x0003c] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Game.cs:852 
  at OpenRA.Game.InitializeAndRun (System.String[] args) [0x00010] in /home/fazal/Sync/infra-idp-app/packages/ra2/engine/OpenRA.Game/Game.cs:274 
  at OpenRA.Launcher.Program.Main (System.String[] args) [0x00044] in /home/fazal/packages/ra2/engine/OpenRA.Launcher/Program.cs:30
mfzl commented 1 year ago

Don't commit lua51.so

@Mailaender thanks for catching this. It was accidental

Mailaender commented 1 year ago

Can you squash your commits?