Update mod to release-20230225

OpenRA / ra2

A Red Alert 2 mod for the OpenRA game engine

GNU General Public License v3.0

965 stars 158 forks source link

Update mod to release-20230225 #806

Closed penev92 closed 1 year ago

penev92 commented 1 year ago

The time has come around for the spiritual successor of #778.

To ease the review as much as possible this uses the latest ModSDK version from https://github.com/OpenRA/OpenRAModSDK/pull/183, the same as TDHD's release-20230225 uses.

The last commit still needs work - chrome changes are not my strong side. Everything except that should be reviewable. Help with the UI is welcome.

Closes #580.

abcdefg30 commented 1 year ago

Commit "Updated ModSDK scripts from "release-20210321" to "release-20230225": Missing https://github.com/OpenRA/OpenRAModSDK/pull/185

penev92 commented 1 year ago

Addressed the above comments.

penev92 commented 1 year ago

Fixed the observer/spectator UI chrome by replacing the newly-added ingame-observer.yaml in commit "Manual mod updates PART 1 - mod.yaml" with the correct one (was a copy of RA's, now is a copy of the removed Common one), so removed the last commit - "SEND HELP - Observer/Spectator UI chrome" as the chrome definitions don't need adjustment after all.

This should now be complete and ready for a full review.

penev92 commented 1 year ago

Added voxel vehicle tilting on slopes as a bonus commit.

MustaphaTR commented 1 year ago

Did a quick test, i noticed several issues (dropdowns have no separator, paradropping GIs are rendering normal body in addition to paradrop frame, deployed GIs do not turn, Soviet ConYard do not have damaged frames) but none seem to be related to/regressions from the update. One thing i think this PR could additionally have is applying https://github.com/OpenRA/OpenRA/pull/17783 but that could stay for another PR too.

About the ToDos you left on chrome.yaml you can copy those from RV, they are already properly updated there: https://github.com/MustaphaTR/Romanovs-Vengeance/blob/master/mods/rv/chrome.yaml

penev92 commented 1 year ago

Copied the chrome definitions that had newly-added TODOs from RV.
Added a "Bonus" commit to fix the missing dropdown separators, which had a TODO from #778. (credited that to @MustaphaTR as he's the one who came up with the coordinates).
Added a "Bonus" commit to add InfiltrateForSupportPowerReset (https://github.com/OpenRA/OpenRA/pull/17783 / https://github.com/OpenRA/ra2/issues/580).

There are more TODOs left over from #778 and things that aren't this PR's concern so it would probably be best not to address them here, as this is already quite big.

penev92 commented 1 year ago

Added another small commit to fix content installer paths.

Mailaender commented 1 year ago

Please clear https://github.com/OpenRA/ra2/pulls before merging this.

penev92 commented 1 year ago

Rebased.