OpenRCT2 / Localisation

Repository for translation and discussion for OpenRCT2.
66 stars 205 forks source link

Replace typewriter quotes #2121

Open Gymnasiast opened 3 years ago

Gymnasiast commented 3 years ago

The straight quotation marks - ' and " - were introduced by typewriters to save space, which carried over to ASCII.

Since the late 90s, there is little need to use them, as proper quotations have been introduced since. For example, this means you should use “ ” and ‘ ’ for quotation marks (at least in English, other languages can have different quotation marks such as « ») and ’ as an apostrophe.

More info can be found here: https://en.wikipedia.org/wiki/Quotation_mark

The typewriter quotes should be replaced everywhere except in technical strings such as <Mel's World>. And if present, the backtick (`) should be replaced with ‘.

Note that you will need to replace the characters in both the interface translation and objects translation.

Updated in:

Notification when new strings arrive: @Omaranwa @J0anJosep @octaroot @LPSGizmo @danidoedel @Wuzzy2 @tellovishous @JasperGray @Wirlie @JoelTroch @anon569 @LucaRed @AaronVanGeffen @telk5093 @Goddesen @Gymnasiast @renansimoes @Tupaschoal @Nubbie @izhangfei @daihakken @marcinkunert

Wuzzy2 commented 3 years ago

I also like to add: The ASCII apostrophe (U+0027) can be replaced with U+2019: https://en.wikipedia.org/wiki/%E2%80%99

Gymnasiast commented 3 years ago

I also like to add: The ASCII apostrophe (U+0027) can be replaced with U+2019: https://en.wikipedia.org/wiki/%E2%80%99

I already said that in the opening post:

For example, this means you should use “ ” and ‘ ’ for quotation marks ... and ’ as an apostrophe.

galfisk commented 3 years ago

Applied to sv-SE

Gymnasiast commented 3 years ago

@galfisk Also to the objects translation?

galfisk commented 3 years ago

@Gymnasiast to everything in the sv-SE file apart from the technical strings, by search-and-replace.

Gymnasiast commented 3 years ago

There is also https://github.com/OpenRCT2/Localisation/blob/master/objects/sv-SE.json

galfisk commented 3 years ago

Aha, I didn't know about that one. Should I replace quotes only inside the string after "name": ? Can there be any double quotes in there, or are there single quote marks/apostrophes only?

Gymnasiast commented 3 years ago

Leave everything with reference in the field name as-is, but change the rest (name, description, capacity, ...). It is possible that there are double quotes, but those will be encoded as \", so you can search for that.

galfisk commented 3 years ago

Are the non-reference fields supposed to be direct translations of the corresponding reference fields? It seems that way in the en-GB file, but in the sv-SE file some of them are quite a bit different, and in at least one case completely unrelated. I can fix this if needed.

Gymnasiast commented 3 years ago

Yes, they are supposed to be direct translations.

It seems that way in the en-GB file

That file was included by mistake: en-GB is the source language, so every single translation will be equal to the reference.

, but in the sv-SE file some of them are quite a bit different, and in at least one case completely unrelated. I can fix this if needed.

Please do!

galfisk commented 3 years ago

Is there a need for keeping the entries in this file arranged in a specific order? It would be a whole lot easier to keep translations consistent if I could, for instance, group the trains for a specific rollercoaster together like in the object picker. Now they're spread all over. Even entries like rct2.mono1/2/3 are in completely different places. Edit: I've done a first pass and fixed a lot of stuff, but this would be very useful when doing a second fixing, tweaking and consistency pass. I've also tweaked sv-SE.txt to match some stuff in the .json.

Gymnasiast commented 3 years ago

I'm afraid the order has to stay. It's not ideal, and we should really have something like a webtranslator or some other tooling, but that in turn requires us to either switch to a translation system that is supported by standard tools or write something of our own.

galfisk commented 3 years ago

I understand. I'll do what I can to provide a good translation, but it'll take more time. You should probably consider such a system though, it'd make quality translation work a lot easier if done right.

Gymnasiast commented 3 years ago

Well, you're preaching to the choir ;-)

The problem is that I already have so much to do (my day job, OpenRCT2 and several other commitments), which means big projects like this are difficult to pick up. Especially since the current system does work, even if it is sometimes cumbersome to work with. I do plan to look into translations, objects, open scenarios and the documentation once the new save format is there, but that project is dragging on as well.

OmarAglan commented 2 years ago

Well This Issue In Not A Big Problem In Arabic, should I get it ticked or what?