search

OpenRCT2 / OpenRCT2

An open source re-implementation of RollerCoaster Tycoon 2 🎢
https://openrct2.io
GNU General Public License v3.0
13.51k stars 1.55k forks source link

Initial money set during scenario creation for no-money maps is still added to the high score upon scenario completion. #21298

Open HtotheTML opened 9 months ago

HtotheTML commented 9 months ago

Operating System

Windows 10, 64 bit

OpenRCT2 build

OpenRCT2, v0.4.7-137-g7043333 (7043333 on develop) provided by GitHub

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

The bug also exists in the original game (RCT2/RCTC)

Describe the issue

All of the no-money scenarios in RCT2, despite having no cash metric as the name implies, start with money that gets added to the high score upon completing the scenario. By contrast, all of RCT1's no-money maps truly have no initial money, when viewed with the enable money cheat, so no discrepancy is made there.

The majority of RCT2's no-money maps start with 10k initial cash, with two exceptions: Extreme Heights starts with 110k Great Wall of China starts with 5.01m

Rather than go through and patch the initial cash out of all of these maps, I think it would be simpler to have the company value calculation not factor in money when "no money" is enabled.

Steps to reproduce

  1. Open any of the scenarios in RCT2 that have no money (Great Wall of China has the most visible error).
  2. Use cheats to enable money to see how much starting cash there is.
  3. Reset to no-money, complete the scenario as normal.
  4. Observe the high score on the scenario select screen.

Attachments

image

image

ZehMatt commented 9 months ago

We can probably just omit displaying the info when its a no money scenario, not necessarily a bug, it just always keeps track of this.

CookiePLMonster commented 9 months ago

Changing this behaviour sounds risky too, so hiding from the UI is probably optimal.

Harry-Hopkinson commented 9 months ago

I have opened a pull request that should fix this issue. Feel free to test if it solves the problem for you.

HtotheTML commented 9 months ago

Hiding it certainly feels like the easier method...but it also feels like a sidestep; I think people do still want to have a visible high score.

MASHzj commented 9 months ago

Are there any no money scenarios with a time deadline? At least all scenarios without deadline could use the date of completion as a sort of high score.

ZeeMaji commented 9 months ago

I don't really see why using company value for scoring no money scenarios is a bad thing, it still scores your park pretty accurately as your company value is just your park value + your money. So anything that raises park value (building new rides, having high ride stats, getting guests, etc) will also raise company value. Sure money may not be a factor within the scenarios themselves but i don't think it's a bad away of scoring them and it keeps the scoring system consistent between all scenarios.

HtotheTML commented 9 months ago

Are there any no money scenarios with a time deadline? At least all scenarios without deadline could use the date of completion as a sort of high score.

That feels closer to a speedrun statistic rather than a score statistic (though I wouldn't mind a plugin that adds that).