search

OpenRCT2 / OpenRCT2

An open source re-implementation of RollerCoaster Tycoon 2 🎢
https://openrct2.io
GNU General Public License v3.0
13.49k stars 1.55k forks source link

Apparently unused ride types? #5871

Closed X123M3-256 closed 7 years ago

X123M3-256 commented 7 years ago

I was looking at the ride code and I noticed several ride types that appear to be unused. The only place they are referenced outside of a comment is in this function which doesn't seem to do much.

I was wondering if there's a reason these ride types are here? I thought that all the ride types were in use.

IntelOrca commented 7 years ago

In RCT1, all the shops and stalls used to be separate ride types. These unused numbers are those ride types. In theory we could remove the enum constants as they are not used - but we will still have to respect the gaps in the IDs.

Gymnasiast commented 7 years ago

Some slots of RCT1 shops have been filled, though.

IntelOrca commented 7 years ago

@Gymnasiast All I am saying is that all the empty slots are shops or stalls in RCT1 - its not a coincidence.

X123M3-256 commented 7 years ago

Are these slots needed for compatibility with RCT1 save files or could they be used for new ride types?

Gymnasiast commented 7 years ago

@IntelOrca I know, it was an addition to your comment.

@X123M3-256 They're not needed, they were most likely left open for ease of converting. So if for example you'd want to create a 'hybrid coaster' (RMC's Ibox track), you can.

X123M3-256 commented 7 years ago

Do you guys want to keep them open? If I were to submit a PR that adds a new track type in one of these slots, would it be rejected?

Gymnasiast commented 7 years ago

1) No, we don't want to keep them open. 2) I wouldn't. But I'd like Ted's confirmation here.

IntelOrca commented 7 years ago

A new track type? This would need a lot of discussion - I am not sure we would even want to consider that until we have a new save format.