search

OpenRCT2 / objects

Official objects for OpenRCT2
Creative Commons Attribution 4.0 International
24 stars 36 forks source link

Rename custom music and mark as compat objects #251

Closed ZeeMaji closed 1 year ago

ZeeMaji commented 1 year ago

Renames both of the custom music 1/2 styles to legacy custom music 1/2 and marks them as compatibility objects.

Closes #228

Gymnasiast commented 1 year ago

I’m pondering whether it would be a good idea to also clear the translations. After all, they are now no longer correct. OTOH, they are not that incorrect.

ZeeMaji commented 1 year ago

From what i can remember, previous object PRs that changed the en-gb string for an object never cleared the other translations (eg: the path object renames from a year or so ago) and just left them as is until they were updated in the localisation repo.

To be honest in this case it seems pretty minor as the en-gb name was only slightly changed so the translations are still mostly correct, just slightly oudated.

Gymnasiast commented 1 year ago

Yeah, fair enough.

ZeeMaji commented 1 year ago

This will make the old custom music objects (the ones that handle vanilla's custom music implementation) compatibility objects, which means they won't be selectable from the object selection window and can only be imported from old parks and deselected. They don't really serve much of a purpose beyond compatibility with old parks since music objects are a far better way of doing custom music now so marking the old custom music objects as compatibility objects seems sensible.