OpenRCT2 / objects

Official objects for OpenRCT2
Creative Commons Attribution 4.0 International
24 stars 36 forks source link

WWTT Default vehicle color cleanup #292

Closed ZeeMaji closed 9 months ago

ZeeMaji commented 9 months ago

This PR is kind of big so i'll go over the the things that it fixes/improves

Note that these changes only affect newly spawned vehicles from creating a new ride or re-selecting the vehicle, so these changes will not affect old parks or track designs.

  1. The second & third colors for all WWTT ride vehicle default color presets that do not have them enabled are set to bright pink & yellow respectively. This fixes a lot of coloring issues as many of their sprites use the second & third remap (which are pink and yellow respectively) palettes unintentionally due to oversights from when frontier originally rendered the sprites. This is basically the fix from #170 and #268 applied to all WWTT ride vehicles it could possibly apply to. Here's an example with the hot rod trains from TT, note the front car Before: Screenshot_select-area_20240216171659 After: Screenshot_select-area_20240216215301

  2. Where applicable, i've effectively removed the default colors for vehicles which don't have any form of (intended) remapping on their sprites. Replacing all their default colors with a single set of "black" "bright_pink" and "yellow". This is most notable on the lion cars for the mini coaster which had like 30 default presets which were inherited from the vanilla mini coaster cars that were doing nothing.

  3. The hippo submarines from WW are extra broken, something went wrong during their rendering process that caused the primary remap color to be used as a normal color, the intended color appears to be light blue so i have set it to that. This is only a soft fix as we currently can't remove the ability to change the primary color so the glitchy remap is still usable by users. They also erroneously had their second color enabled so i've also fixed that as it doesn't seem to be intended to be used (just changes random pixels inside the mouth when the "restraints" are open).

Hippo submarines with these fixes applied Screenshot_select-area_20240216202619