search

OpenRCT2 / objects

Official objects for OpenRCT2
Creative Commons Attribution 4.0 International
24 stars 36 forks source link

Add sloped sprites to wallcb8, wallcb16, and wallcb32 #308

Closed fidwell closed 8 months ago

fidwell commented 8 months ago

The next of my sloped wall PRs. As before, these sprites were made by ripping existing sprites and hand-editing in Paint.NET.

Pinging @ZeeMaji for review.

wallcb8 wallcb16 wallcb32

Comparison with RCT1 terrain edge:

image

ZeeMaji commented 8 months ago

Looks good to me, also i would like to note that there's an odd error with the gray sandstone edge once you get to the recolorable sandstone walls, For some reason the gray sandstone edge is shifted vertically upwards by one pixel compared to the brown sandstone. Don't think you need to really account for it as i don't think the recolorable RCT2 wall is affected by this but i felt like it was worth mentioning as it's quite odd.

Gymnasiast commented 8 months ago

@fidwell Could you make sure your commit messages are descriptive? Making them the same as your PR titles is OK, but now I have to rewrite wallcb to Add sloped sprites to wallcb8, wallcb16, and wallcb32 every time.

fidwell commented 8 months ago

My apologies @Gymnasiast — I assumed GitHub would use the name of the PR as the commit, but I guess not. I'll use better commit messages in the future.