search

OpenRCT2 / objects

Official objects for OpenRCT2
Creative Commons Attribution 4.0 International
24 stars 36 forks source link

Add sloped sprites to wallcf8, wallcf16, and wallcf32 #311

Closed fidwell closed 6 months ago

fidwell commented 6 months ago

The next of my sloped wall PRs. As before, these sprites were made by ripping existing sprites and hand-editing in Paint.NET. Pinging @ZeeMaji for review.

wallcf8 wallcf16 wallcf32

One interesting thing about this wall is that (I think) it is meant to match the shiny castle walls, which have sloped sprites but those sprites do not line up with the ground—they are shifted up by a pixel, so they hover off the ground. In this screenshot, on the left are two 16-high walls, and on the right is a 16-high wall with a castle wall atop it. You can see the seam. This seems like an issue with the castle wall itself and I don't think that wallcf should replicate this behavior.

image

ZeeMaji commented 6 months ago

How do they look when they're combined with the gray sandstone edge?

Also don't worry about the castle walls, they're bugged due to something that went wrong with their offsets in RCT2 as that issue is not present in RCT1. this will likely be fixed in the future. (it also affects a few other wall types)

fidwell commented 6 months ago

image

ZeeMaji commented 6 months ago

Looks good to me.

Gymnasiast commented 6 months ago

@fidwell You are indeed correct about the castle walls being off by a pixel, and that your object should not replicate it. I intend to fix that, but it requires some additional code since it reads its stuff from a .DAT object.