OpenRCT2 / objects

Official objects for OpenRCT2
Creative Commons Attribution 4.0 International
23 stars 35 forks source link

Fix mandarin duck boats capacity #320

Closed ZeeMaji closed 3 months ago

ZeeMaji commented 3 months ago

This vehicle erroneously has it's seats set to 4 when only 2 guests are visible on the boat at a time. Due to some weirdness with how the swan boats animation style (animation: 2) is handled i've switched them over to the water trikes animation (animation: 5) which lets us shave off some dummy blank images the original object had to include as a hacky workaround for the swans animation style always expecting 2 sets of guest sprites (+1 for the animation if you want to count that) in a strange order.

On old saves that still have the duck vehicles spawned, they will retain their old capacity of 4 so this doesn't affect old saves. However due to the change in animation style there's a chance that on the first initial tick the sprites will be glitched as i believe it's still technically using the swans animation style for the first tick which will result in the second animation frame using some images from outside of the object's images table. After the first tick it fixes itself as it switches to the trikes animation so it's not super noticeable but i felt like it was worth mentioning just incase.

For the capacity string i've only changed en-GB, not really sure if i should change the others as it'd probably be cleaner to change them on the localisation repo.

ZeeMaji commented 3 months ago

Hmm, are you sure it would be a good idea? There's some object string changes in the localisation repo so i'm not sure if the next localisation sync would overwrite this.

Gymnasiast commented 3 months ago

Yes, I always perform that sync and I’m fully aware of the implications.

ZeeMaji commented 3 months ago

Hmm, well alright.