search

OpenRCT2 / openrct2-dependencies-android

3 stars 4 forks source link

speexdsp compiles different files than android project used to #6

Closed marijnvdwerf closed 8 years ago

marijnvdwerf commented 8 years ago 
  buffer.c
  fftwrap.c
  filterbank.c
  jitter.c
- kiss_fft.c
- kiss_fftr.c
  mdf.c
  preprocess.c
  resample.c
  scal.c
  smallft.c
- -DFIXED_POINT
+ -DFLOATING_POINT
- -DUSE_KISS_FFT
  -DHAVE_STDINT_H
LRFLEW commented 8 years ago

You said you're using the ./configure script, right? The flags should be --enable-fixed-point --with-fft=kiss

marijnvdwerf commented 8 years ago

Already fixed in one of the last commits. The latter Isn't neccesary though. But I don't know how to properly behave on each architecture. Op zo 30 okt. 2016 om 23:55 schreef LRFLEW notifications@github.com

You said you're using the ./configure script, right? The flags should be --enable-fixed-point --with-fft=kiss

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marijnvdwerf/openrct2-dependencies-android/issues/6#issuecomment-257186252, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtBQ7XGkLeS_99VFSqTEzQBCY6nvv6pks5q5SB1gaJpZM4KkdKs .

LRFLEW commented 8 years ago

I'd say that x86 (and it's related architecture x86_64) has good/decent floating point performance, so use floating point there. Everything else we can assume doesn't have the best floating point performance, and use fixed point there. That's how I'd do it at least.

marijnvdwerf commented 8 years ago

ANDROID_CPU_ARM64_FEATURE_FP Indicates that the device's CPU has a Floating Point Unit (FPU). All Android ARM64 devices must support this feature.

marijnvdwerf commented 8 years ago

Fixed by 0eedf24