OpenRIAServices / OpenRiaServices

The Open RIA Services project continues what was previously known as WCF RIA Services.
https://openriaservices.gitbook.io/openriaservices/
Apache License 2.0
54 stars 48 forks source link

WS-2022-0161 (High) detected in microsoft.vssdk.buildtools.16.11.69.nupkg, newtonsoft.json.10.0.1.nupkg - autoclosed #404

Closed mend-bolt-for-github[bot] closed 10 months ago

mend-bolt-for-github[bot] commented 1 year ago

WS-2022-0161 - High Severity Vulnerability

Vulnerable Libraries - microsoft.vssdk.buildtools.16.11.69.nupkg, newtonsoft.json.10.0.1.nupkg

microsoft.vssdk.buildtools.16.11.69.nupkg

Contains targets and tools to enable the building of managed VSIX projects without VSSDK MSI installed. Only for VS 2015 and onwards.

Library home page: https://api.nuget.org/packages/microsoft.vssdk.buildtools.16.11.69.nupkg

Path to dependency file: /src/VisualStudio/Installer/OpenRiaServices.VisualStudio.Installer.csproj

Path to vulnerable library: /home/wss-scanner/.nuget/packages/microsoft.vssdk.buildtools/16.11.69/microsoft.vssdk.buildtools.16.11.69.nupkg

Dependency Hierarchy: - :x: **microsoft.vssdk.buildtools.16.11.69.nupkg** (Vulnerable Library)

newtonsoft.json.10.0.1.nupkg

Json.NET is a popular high-performance JSON framework for .NET

Library home page: https://api.nuget.org/packages/newtonsoft.json.10.0.1.nupkg

Path to dependency file: /src/VisualStudio/Tools/Test/OpenRiaServices.VisualStudio.DomainServices.Tools.Test.csproj

Path to vulnerable library: /home/wss-scanner/.nuget/packages/newtonsoft.json/10.0.1/newtonsoft.json.10.0.1.nupkg

Dependency Hierarchy: - EFCoreModels-1.0.0 (Root Library) - microsoft.entityframeworkcore.sqlserver.3.1.32.nupkg - microsoft.data.sqlclient.1.1.3.nupkg - microsoft.identitymodel.protocols.openidconnect.5.5.0.nupkg - microsoft.identitymodel.protocols.5.5.0.nupkg - microsoft.identitymodel.tokens.5.5.0.nupkg - :x: **newtonsoft.json.10.0.1.nupkg** (Vulnerable Library)

Found in HEAD commit: 2505fca835708b6a24650d21bd678cff09bb49e8

Found in base branch: main

Vulnerability Details

Newtonsoft.Json prior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of expressions with high nesting level that lead to StackOverFlow exception or high CPU and RAM usage. Exploiting this vulnerability results in Denial Of Service (DoS). \n\nThe serialization and deserialization path have different properties regarding the issue.\n\nDeserializing methods (like `JsonConvert.DeserializeObject`) will process the input that results in burning the CPU, allocating memory, and consuming a thread of execution. Quite high nesting level (>10kk, or 9.5MB of `{a:{a:{...` input) is needed to achieve the latency over 10 seconds, depending on the hardware.\n\nSerializing methods (like `JsonConvert.Serialize` or `JObject.ToString`) will throw StackOverFlow exception with the nesting level of around 20k.\n\nTo mitigate the issue one either need to update Newtonsoft.Json to 13.0.1 or set `MaxDepth` parameter in the `JsonSerializerSettings`. This can be done globally with the following statement. After that the parsing of the nested input will fail fast with `Newtonsoft.Json.JsonReaderException`:\n\n``` \nJsonConvert.DefaultSettings = () => new JsonSerializerSettings { MaxDepth = 128 };\n```\n\nRepro code:\n```\n//Create a string representation of an highly nested object (JSON serialized)\nint nRep = 25000;\nstring json = string.Concat(Enumerable.Repeat(\"{a:\", nRep)) + \"1\" +\n string.Concat(Enumerable.Repeat(\"}\", nRep));\n\n//Parse this object (leads to high CPU/RAM consumption)\nvar parsedJson = JsonConvert.DeserializeObject(json);\n\n// Methods below all throw stack overflow with nRep around 20k and higher\n// string a = parsedJson.ToString();\n// string b = JsonConvert.SerializeObject(parsedJson);\n```\n\n### Additional affected product and version information\n**The original statement about the problem only affecting IIS applications is misleading.** Any application is affected, however the IIS has a behavior that stops restarting the instance after some time resulting in a harder-to-fix DoS.**

Publish Date: 2022-06-22

URL: WS-2022-0161

CVSS 3 Score Details (7.5)

Base Score Metrics: - Exploitability Metrics: - Attack Vector: Network - Attack Complexity: Low - Privileges Required: None - User Interaction: None - Scope: Unchanged - Impact Metrics: - Confidentiality Impact: None - Integrity Impact: None - Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version

Release Date: 2022-06-22

Fix Resolution: Newtonsoft.Json - 13.0.1;Microsoft.Extensions.ApiDescription.Server - 6.0.0


Step up your Open Source Security Game with Mend here

mend-bolt-for-github[bot] commented 1 year ago

:heavy_check_mark: This issue was automatically closed by Mend because the vulnerable library in the specific branch(es) was either marked as ignored or it is no longer part of the Mend inventory.

mend-bolt-for-github[bot] commented 11 months ago

:information_source: This issue was automatically re-opened by Mend because the vulnerable library in the specific branch(es) has been detected in the Mend inventory.

mend-bolt-for-github[bot] commented 10 months ago

:heavy_check_mark: This issue was automatically closed by Mend because the vulnerable library in the specific branch(es) was either marked as ignored or it is no longer part of the Mend inventory.