search

OpenRIAServices / OpenRiaServices

The Open RIA Services project continues what was previously known as WCF RIA Services.
https://openriaservices.gitbook.io/openriaservices/
Apache License 2.0
54 stars 47 forks source link

Fix adding EndPointBehaviours to ChannelFactory #431

Closed SandstromErik closed 1 year ago

SandstromErik commented 1 year ago

Fix adding EndPointBehaviors To ChannelFactory outside of the CreateChannelFactory method

SandstromErik commented 1 year ago

@Daniel-Svensson saw that you added this in #184, do you see any problem with this change? If so, do you have any other solution ideas?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Daniel-Svensson commented 1 year ago

@Daniel-Svensson saw that you added this in #184, do you see any problem with this change? If so, do you have any other solution ideas?

I would be very hesitant to make the change.

That would mean that the synronization context when the first domaincontext call is performed will capture the current syncronisationContext and use that for all future calls even if it becomes invalid or they are made on completely different synronization context.

Further I dont think it will solve the problem, I will add a comment on the issue instead