search

OpenROADM / OpenROADM_MSA_Public

Open ROADM MSA
http://www.openroadm.org/
62 stars 79 forks source link

node-id-type length is miss-matching with Pattern regular expression #28

Closed ashuagarwal01 closed 5 years ago

ashuagarwal01 commented 6 years ago

Hi,

The node-id-type length is defined as 7..63. But the pattern is limiting the length to 20 characters.

typedef node-id-type { type string { length "7..63"; pattern "([a-zA-Z][a-zA-Z0-9-]{5,18}[a-zA-Z0-9])" { error-message "A node-id must be 7 to 63 characters in length. A node-id can contain letters, numbers, and hyphens. The first character must be a letter. The last character must be a letter or number."; }

The correct pattern should be like this: pattern "([a-zA-Z][a-zA-Z0-9-]{5,61}[a-zA-Z0-9])"

fgruman commented 5 years ago

Fixed in 5.0: typedef node-id-type { type string { length "7..63"; pattern "([a-zA-Z][a-zA-Z0-9-]{5,61}[a-zA-Z0-9])" {

dhruv2180 commented 5 years ago

@ashuagarwal01 this issue has been addressed, closing the issue, let us know if you still have any questions.