OpenROADM / OpenROADM_MSA_Public

Open ROADM MSA
http://www.openroadm.org/
62 stars 79 forks source link

Feature Request Node Types #3

Closed damianoneill closed 6 years ago

damianoneill commented 7 years ago

In org-openroadm-common-types.yang there is a type defined for node type. Please consider adding an additional enum as a catch all for a node type other than a ROADM or Transponder/Regen.

This would allow an implementor to augment the model with a vendor specific typedef to be used when the standard node-types is set as other, allowing the model to remain specific (optical focused).

For e.g.

  typedef node-types {
    type enumeration {
      enum "rdm" {
        value 1;
      }
      enum "xpdr" {
        value 2;
      }
      enum "other" {
        value 3;
      }
    }
    description
      "3 digit identifier for node type
       1. rdm for ROADM
       2. xpdr for Transponder, Regen";
  }

As an aside, the description text indicates that the node type is a 3 digit identifier, xpdr is 4.

Thanks.

damianoneill commented 7 years ago

Additional context, looking at the whitepaper Open-ROADM-Network-Model-Whitepaper-v1-1.pdf the implication is that the Node Type is to be three things:

Should this request also include updating the YANG to reflect the PLG requirement?