OpenROADM / OpenROADM_MSA_Public

Open ROADM MSA
http://www.openroadm.org/
61 stars 77 forks source link

Password field/leaf in User Management model #48

Open sumittrehan opened 4 years ago

sumittrehan commented 4 years ago

Hi,

The 'password' leaf in the user management model specifies the following regex pattern: [a-zA-Z0-9!$%\^()[]_-~{}.+]* The observation is that it does contain the character '/'. We want to store the sha-512 based hash password which consists of the set [./a-zA-Z0-9]. Since the allowed charset excludes '/', this would fail. Can you please include '/' in the allowed regex ? Any reason for not including the '/' in the allowed pattern ?

Thanks

beegeesquare commented 4 years ago

There was no specific reason for excluding '/'. However if you still require to need it, please submit a PR in the private respository.

fgruman commented 4 years ago

The password field is meant to convey the actual password in clear text. There is an issue with the description for the attribute that needs to be cleaned up and will be addressed in the next version of the MSA model.

The intent of the password field was not convey the SHA-512 hash.

When selecting the special characters supported in the password field, the list was decided by an approximate least common denominator of the characters that the MSA vendors supported. There was a few debates about removing password characters because some characters were not supported by some vendors.

For instance, the "&" character was initially proposed but later removed based on vendor feedback.

If the intent is to convey a SHA hash option, this may be better to support as a new attribute vs using the existing password attribute.