search

OpenROADM / OpenROADM_MSA_Public

Open ROADM MSA
http://www.openroadm.org/
65 stars 79 forks source link

Disparity between "must" and "error-message" #50

Open AjeyBharadwaj opened 4 years ago

AjeyBharadwaj commented 4 years ago

https://github.com/OpenROADM/OpenROADM_MSA_Public/blob/aaa5a0e103e0e69c9b7c823e02bdca40257a0048/model/Common/org-openroadm-manifest-file.yang#L477

The "must" constraint expects "is-async" field to be false. But, error says : "sw-activate is only supported as async command"

fgruman commented 4 years ago

I'll investigate and sent a query to the modeling team. But I believe you are correct. If so, then all of the must statements associated with is-async may be incorrect in this module (3 instances identified).

EXISTING: container sw-activate { when "../command = 'sw-activate'"; must "is-async != 'true'" { error-message "sw-activate is only supported as async command"; } CHECKING if it should be: grouping sw-activate-command { description "sw-activate-command"; container sw-activate { when "../command = 'sw-activate'"; must "is-async = 'true'" { error-message "sw-activate is only supported as async command"; }

fgruman commented 4 years ago

@AjeyBharadwaj this is planned to be fixed in the MSAv8.0 release

fgruman commented 3 years ago

@AjeyBharadwaj This has been fixed in MSAv8.0.