search

OpenROADM / OpenROADM_MSA_Public

Open ROADM MSA
http://www.openroadm.org/
62 stars 79 forks source link

Type of command is not correct #51

Open AjeyBharadwaj opened 4 years ago

AjeyBharadwaj commented 4 years ago

The type of leaf "command" is : "base sw-manifest-commands;" But, for "delete-file" option in "delete-file-command" to be accesible, it should be of type "base manifest-commands;"

I think the leaf "command" should be a union of "base sw-manifest-commands;" and "base manifest-commands;"

Type of command : https://github.com/OpenROADM/OpenROADM_MSA_Public/blob/aaa5a0e103e0e69c9b7c823e02bdca40257a0048/model/Common/org-openroadm-manifest-file.yang#L838

Type of delete-file : https://github.com/OpenROADM/OpenROADM_MSA_Public/blob/aaa5a0e103e0e69c9b7c823e02bdca40257a0048/model/Common/org-openroadm-manifest-file.yang#L97

Condtion : https://github.com/OpenROADM/OpenROADM_MSA_Public/blob/aaa5a0e103e0e69c9b7c823e02bdca40257a0048/model/Common/org-openroadm-manifest-file.yang#L401

fgruman commented 4 years ago

@AjeyBharadwaj I just got a chance to look at this item.

i think the issue that you are describing is as follows: In SWDL, the command type is sw-manifest-commands. However, to do a SWDL operation, we may need to issue the file transfer command. But the file transfer (and delete) commands are under the identity type of manifest-commands, not sw-manifest-commands.
So we would not be able to specify download-file, upload-file, or delete-file in the SWDL process as they do not conform to the base sw-manifest-commands.

This issue would also be in the database backup and restore sections.

Is this a correct understanding?

AjeyBharadwaj commented 4 years ago

Yes. We might have to change the base identity of all options to one (not a good design) OR, make type of command as union which accepts from both identity refs.