codewithpassion
commented
9 years ago While I agree with the general idea of looking into moving away from the modifier keys, I'm not sure if the move to a left hand driven ROV makes that much sense for most people.
The left hand control style comes from the fact that FPS games use a mouse for control and we don't have a dedicated mouse control in mind I believe.
Given that, if I interpret the mapping correctly, I need now both hands on the keyboard to move to ROV forward and up/down where's today, with most keyboards having a ctr/shift close to the arrow keys, I can use one hand.
In any case, if it should be decided to go ahead, we have to be able to give the user's an easy way to switch to the 'old style' controls. The input controller is setup to accept different mappings so a profile solution should be easy to add.
Ultimately, we might as well just implement the ui to assign your own profiles when we do this change.
I strongly disagree with moving away from the current scheme with no way back (and editing code is not a valid way to go back). On Mar 25, 2015 3:35 AM, "badevguru" notifications@github.com wrote:
The goal for this change is:
- Make it more intuitive on how to control the ROV
- Move away from using the modifier keys (crtl.fn,shift) that when combined with other keys overlaps with reserved commands that we cannot override (such as Ctrl+Arrow Key in OSX that cause the screen to swap to another screen).
The proposed key combination would be: Movement Controls: Key Command W move forward S move back A strafe left (reserved) D strafe right (reserved) Q roll left E roll right Up left up -or- pitch down Down lift down -or- pitch up Left yaw left Right yaw right Shift-W pitch down -or- lift up Shift-S pitch up -or- lift down Secondary Controls: Key Command I/K camera tilt J/L reserved camera pan O/U reserved camera zoom G depth hold H heading hold 1-5 motor power settings 6-7 light dim/bright 8 lasers on 9,0 reserve for illumination controls
The -or- commands show where the keyboard flops to give priority to the primary movement axis used to execute overall vertical adjustments. So a ROV that tends to pitch to change depth would have pitch controls as the primary on the up/down arrows while a ROV that uses dedicated thrusters would have those as primary.
This also allows for no change in the left hand keyboard commands when introducing a mouse.
For the secondary controls I have focused on trying to keep like controls spaced together in a way that supports simple recall.
- Power associated things on the number key, thruster power on left, illumination controls on right
- Reserving another 2-axis key combination (I,J,K,L) for camera gimbal
- Place the holds next to each other, keying off of the H for a heading hold and putting depth hold right next to it in G.
This needs to be driven extensively and tested. It is not meant to prevent customization, but is instead proposing the initial default keyboard layout to achieve the goals meant at the beginning of the document.
— Reply to this email directly or view it on GitHub https://github.com/OpenROV/openrov-software/issues/369.
spiderkeys
gilborty
BrianAdams
The goal for this change is:
The proposed key combination would be:
Movement Controls:
Secondary Controls:
The -or- commands show where the keyboard flops to give priority to the primary movement axis used to execute overall vertical adjustments. So a ROV that tends to pitch to change depth would have pitch controls as the primary on the up/down arrows while a ROV that uses dedicated thrusters would have those as primary.
This also allows for no change in the left hand keyboard commands when introducing a mouse.
For the secondary controls I have focused on trying to keep like controls spaced together in a way that supports simple recall.
This needs to be driven extensively and tested. It is not meant to prevent customization, but is instead proposing the initial default keyboard layout to achieve the goals meant at the beginning of the document.