OpenROV / openrov-software

Meta project for all of the OpenROV Software projects
http://openrov.com
Other
422 stars 188 forks source link

Need to add a battery preset for the NMC batteries #600

Open BrianAdams opened 7 years ago

BrianAdams commented 7 years ago

@briangrau , these are just for Trident, correct?

spiderkeys commented 7 years ago

If this is for Trident, then this plugin won't be employed. The battery management IC provides all of the processed information and telemetry relating to the batteries.

If this is for the 2X, let me know and I can add a new battery class.

briangrau commented 7 years ago

This is for the 2-series. These are the blue batteries (the ones we used in the Deep Units). These are in the store and so the battery configuration should be in the software as well. You just need the upper and lower voltage limits?

spiderkeys commented 7 years ago

Please advise the voltages and I can wrap this one up :)

spiderkeys commented 7 years ago

Added in pending PR: https://github.com/OpenROV/openrov-cockpit/pull/183