OpenROV / openrov-software

Meta project for all of the OpenROV Software projects
http://openrov.com
Other
423 stars 189 forks source link

geomuxpp is unintentionally skipping the MP4 FTYP header #614

Open spiderkeys opened 7 years ago

spiderkeys commented 7 years ago

In the step where we write the stream header information, we are unintentionally dropping the FTYP container of the stream because of an error in the conditional logic that handles compositing the ZMQ multipart message ("i", FTYP, MOOV) resulting in a message that is instead ("i", MOOV). This doesn't impact live streaming, and the browsers can also seem to play the MP4 files without the FTYP box, so this isn't immediately impacting anything, but should be corrected for pickier media players.

Since geomuxpp is being replaced by geoserve (currently in active development) and is non-critical, this bug will be fixed in geoserve.