Ubuntu 18.10 で master ブランチのビルドに失敗する

[tonboAkinori]

Describe the bug Ubuntu 18.10 で master ブランチのビルドに失敗する

Ubuntu 18.04の g++ 7.3 ではビルド成功、18.10 の 8.2 では失敗

• g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
• g++ (Ubuntu 8.2.0-7ubuntu1) 8.2.0

To Reproduce Steps to reproduce the behavior:

1. Dockerのベースイメージを 18.10 にする

   • build/ubuntu_1604/Dockerfile を変更

2. docker build を実施

3. 下記エラーが出力され、ビルドに失敗する

   /root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:247:33: error: no match for 'operator!=' (operand types are 'boost::system::error_code' and 'std::nullptr_t')
          if (!result || (error != nullptr))
                          ~~~~~~^~~~~~~~~~

   Reproducibility 100 %

Expected behavior ビルドが成功すること

Screenshots or Logs

/root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp: In member function 'void RTM::LocalService::FileNameservice::onUnregisterNameservice(coil::vstring&)':
/root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:247:33: error: no match for 'operator!=' (operand types are 'boost::system::error_code' and 'std::nullptr_t')
           if (!result || (error != nullptr))
                           ~~~~~~^~~~~~~~~~
In file included from /usr/include/omniORB4/CORBA.h:216,
                 from /root/OpenRTM-aist/src/lib/rtm/RTC.h:50,
                 from /root/OpenRTM-aist/src/lib/rtm/Manager.h:23,
                 from /root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:22:
/usr/include/omniORB4/fixed.h:50:16: note: candidate: 'CORBA::Boolean operator!=(const CORBA::Fixed&, const CORBA::Fixed&)'
 CORBA::Boolean operator!=(const CORBA::Fixed& a, const CORBA::Fixed& b);
                ^~~~~~~~
/usr/include/omniORB4/fixed.h:50:16: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'const CORBA::Fixed&'
In file included from /usr/include/boost/filesystem/path_traits.hpp:23,
                 from /usr/include/boost/filesystem/path.hpp:25,
                 from /usr/include/boost/filesystem.hpp:16,
                 from /root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:20:
/usr/include/boost/system/error_code.hpp:599:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_code&, const boost::system::error_code&)'
     inline bool operator!=( const error_code & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:599:17: note:   no known conversion for argument 2 from 'std::nullptr_t' to 'const boost::system::error_code&'
/usr/include/boost/system/error_code.hpp:605:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_condition&, const boost::system::error_condition&)'
     inline bool operator!=( const error_condition & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:605:17: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'const boost::system::error_condition&'
/usr/include/boost/system/error_code.hpp:618:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_code&, const boost::system::error_condition&)'
     inline bool operator!=( const error_code & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:618:17: note:   no known conversion for argument 2 from 'std::nullptr_t' to 'const boost::system::error_condition&'
/usr/include/boost/system/error_code.hpp:631:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_condition&, const boost::system::error_code&)'
     inline bool operator!=( const error_condition & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:631:17: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'const boost::system::error_condition&'
/root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp: In member function 'bool RTM::LocalService::FileNameservice::createDirectory(boost::filesystem::path&)':
/root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:276:33: error: no match for 'operator!=' (operand types are 'boost::system::error_code' and 'std::nullptr_t')
           if (!result || (error != nullptr))
                           ~~~~~~^~~~~~~~~~
In file included from /usr/include/omniORB4/CORBA.h:216,
                 from /root/OpenRTM-aist/src/lib/rtm/RTC.h:50,
                 from /root/OpenRTM-aist/src/lib/rtm/Manager.h:23,
                 from /root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:22:
/usr/include/omniORB4/fixed.h:50:16: note: candidate: 'CORBA::Boolean operator!=(const CORBA::Fixed&, const CORBA::Fixed&)'
 CORBA::Boolean operator!=(const CORBA::Fixed& a, const CORBA::Fixed& b);
                ^~~~~~~~
/usr/include/omniORB4/fixed.h:50:16: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'const CORBA::Fixed&'
In file included from /usr/include/boost/filesystem/path_traits.hpp:23,
                 from /usr/include/boost/filesystem/path.hpp:25,
                 from /usr/include/boost/filesystem.hpp:16,
                 from /root/OpenRTM-aist/src/ext/local_service/nameservice_file/FileNameservice.cpp:20:
/usr/include/boost/system/error_code.hpp:599:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_code&, const boost::system::error_code&)'
     inline bool operator!=( const error_code & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:599:17: note:   no known conversion for argument 2 from 'std::nullptr_t' to 'const boost::system::error_code&'
/usr/include/boost/system/error_code.hpp:605:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_condition&, const boost::system::error_condition&)'
     inline bool operator!=( const error_condition & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:605:17: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'const boost::system::error_condition&'
/usr/include/boost/system/error_code.hpp:618:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_code&, const boost::system::error_condition&)'
     inline bool operator!=( const error_code & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:618:17: note:   no known conversion for argument 2 from 'std::nullptr_t' to 'const boost::system::error_condition&'
/usr/include/boost/system/error_code.hpp:631:17: note: candidate: 'bool boost::system::operator!=(const boost::system::error_condition&, const boost::system::error_code&)'
     inline bool operator!=( const error_condition & lhs,
                 ^~~~~~~~
/usr/include/boost/system/error_code.hpp:631:17: note:   no known conversion for argument 1 from 'boost::system::error_code' to 'const boost::system::error_condition&'
[ 79%] Linking CXX shared library ExtendedFsmServiceProvider.so
[ 79%] Built target ExtendedFsmServiceProvider
Scanning dependencies of target LogicalTimeTriggeredEC
[ 80%] Linking CXX shared library LogicalTimeTriggeredEC.so
make[2]: *** [src/ext/local_service/nameservice_file/CMakeFiles/FileNameservice.dir/build.make:63: src/ext/local_service/nameservice_file/CMakeFiles/FileNameservice.dir/FileNameservice.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1628: src/ext/local_service/nameservice_file/CMakeFiles/FileNameservice.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 80%] Built target LogicalTimeTriggeredEC
make: *** [Makefile:130: all] Error 2
The command '/bin/sh -c cmake -DCORBA=omniORB -DCMAKE_BUILD_TYPE=Release -DSSL_ENABLE=ON -DOBSERVER_ENABLE=ON -S . -Bbuild_openrtm && cmake --build build_openrtm -- -j$(nproc)' returned a non-zero code: 2

Environment

• OS: Ubuntu 18.10 on Docker
• branch: master (c18426c)

Additional context

[r-kurose]

ログからは boost の仕様変更に見えますね。

[r-kurose]

233 で同じ部分に修正の話があるので注意。

[tonboAkinori]

233 で指摘されている部分が修正されれば問題なくなります。

@Nobu19800 さんの指摘にある通り error は使われていないという指摘で 指摘部分の error =! nullptr を削除すれば、ビルドが通ることは確認済みです。

[tonboAkinori]

476 がマージされたブランチ (4fd2a4f) で本チケットに関して確認を行い、

問題が解決されていることを確認できたためクローズする。

■ #476 がマージされる前のブランチ(08a6a98)をUbuntu18.10でビルドすると失敗することを確認

• 以下は確認手順
  1. OpenRTM-aist/scripts/Ubuntu18.04/Docker_devel-rtm で ベースイメージを 18.10 に変更
  2. OpenRTM-aist/scripts/Ubuntu18.04/Docker で ベースイメージを 1. で作成したイメージに変更

■#476 がマージされる後のブランチ(4fd2a4f)をUbuntu18.10でビルドして成功することを確認

• 以下は確認手順 手順はビルド失敗確認時の手順と同じ。