search

OpenRTM / OpenRTM-aist

OpenRTM-aist: RT-Middleware and OMG RTC implementation in C++ implemented by AIST
https://openrtm.org/
Other
19 stars 12 forks source link

SimpleService/LogicalTimeTriggeredEC has warnings from generated code. #280

Closed r-kurose closed 5 years ago

r-kurose commented 5 years ago

Describe the bug SimpleService をビルドすると、生成ファイルでワーニングが発生する。

To Reproduce

  1. cmake -DCORBA=omniORB -S . -B/tmp/build -DCMAKE_BUILD_TYPE=Debug
  2. cmake --build /tmp/build

Reproducibility 100%

Expected behavior ワーニング無きこと。

Screenshots or Logs 一部抜粋

/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:111:54: warning: use of old-style cast to 'OpenRTM::LogicalTimeTriggeredEC::_ptr_type' {aka 'class OpenRTM::_objref_LogicalTimeTriggeredEC*'} [-Wold-style-cast]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:118:54: warning: use of old-style cast to 'OpenRTM::LogicalTimeTriggeredEC::_ptr_type' {aka 'class OpenRTM::_objref_LogicalTimeTriggeredEC*'} [-Wold-style-cast]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:138:58: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:138:73: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:144:18: warning: 'virtual void OpenRTM::_objref_LogicalTimeTriggeredEC::_enableShortcut(omniServant*, const _CORBA_Boolean*)' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:149:19: warning: 'virtual void* OpenRTM::_objref_LogicalTimeTriggeredEC::_ptrToObjRef(const char*)' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:163:25: warning: 'virtual omniObjRef* OpenRTM::_pof_LogicalTimeTriggeredEC::newObjRef(omniIOR*, omniIdentity*)' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:164:28: warning: 'virtual _CORBA_Boolean OpenRTM::_pof_LogicalTimeTriggeredEC::is_a(const char*) const' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:177:28: warning: 'virtual _CORBA_Boolean OpenRTM::_impl_LogicalTimeTriggeredEC::_dispatch(omniCallHandle&)' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:180:19: warning: 'virtual void* OpenRTM::_impl_LogicalTimeTriggeredEC::_ptrToInterface(const char*)' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:181:25: warning: 'virtual const char* OpenRTM::_impl_LogicalTimeTriggeredEC::_mostDerivedRepoId()' can be marked override [-Wsuggest-override]
/tmp/build/src/ext/ec/logical_time/LogicalTimeTriggeredEC.hh:203:108: warning: use of old-style cast to 'OpenRTM::LogicalTimeTriggeredEC_ptr' {aka 'class OpenRTM::_objref_LogicalTimeTriggeredEC*'} [-Wold-style-cast]

Environment

Additional context なし

Nobu19800 commented 5 years ago

見たところSimpleServiceは関係なさそうです。 LogicalTimeTriggeredEC.hhはomniidlが自動生成したコードなので警告が出ても仕方ないです。

r-kurose commented 5 years ago

生成コードなので警告箇所の修正ではなく、警告レベルの調整で表示しないように修正完了