search

OpenRTMFP / Cumulus

CumulusServer is a complete open source and cross-platform RTMFP server extensible by way of scripting
http://groups.google.com/group/openrtmfp-cumulus
GNU General Public License v3.0
593 stars 221 forks source link

netGroup server bootstrap client connect to himself #92

Closed arpu closed 11 years ago

arpu commented 11 years ago

on client connect the client get the latest 6 connected clients in the netGroup

with new version i get many 14/12 00:41:53.9 WARN RTMFPServer(3078384496) RTMFPServer.cpp[287] A client tries to connect to himself (same 177.43.14.114:59857 address) 14/12 00:41:55.2 WARN RTMFPServer(3078384496) RTMFPServer.cpp[287] A client tries to connect to himself (same 186.241.149.24:56802 address)

so a fix is do not send the last 6 connected clients send random 6 + the broadcast client

cumulusdev commented 11 years ago

No, it's a true bug, thanks I will look it.

By this way, A NetGroup has not necessarily a broadcaster, or can have many broadcasters, you speak for your specific usage case I think. Anyway, the server doesn't know their usage nature. Even if we had a group with just a broadcaster, and that the server owned this information, if you give this member for every new member, RTMFP will use this way to broadcast data (broadcaster -> member), and anymore the true P2P way (member -> member), we had recreate a server->client solution.

Thanks, I will fix it.

cumulusdev commented 11 years ago

I think that it's fixed. Let me know ;-)