search

OpenRTX / dmrconfig

Configuration utility for DMR radios
BSD 3-Clause "New" or "Revised" License
240 stars 56 forks source link

On Anytone 868 and 878, setting a receive tone does not enable tone squelch #34

Closed jdsteele closed 5 years ago

jdsteele commented 5 years ago

On analog channels, setting a CTCSS or DCS value does not also set squelch_mode to SQ_TONE.

sergev commented 5 years ago

Frankly, I'm not sure this is a bug. SQ_TONE mode means you don't want to hear others on this repeater who have a different CTCSS or DCS setting. This seems pretty infrequent situation: a crowded frequency with multiple tones. Dmrconfig sets a SQ_CARRIER mode instead, which means you are going to hear everybody on this frequency.

jdsteele commented 5 years ago

Well, sure. If I want to hear everybody, I set the RxTone column to "-" which implies squelch_mode will be SQ_CARRIER. But if I set RxTone to "100.0", I would expect to only hear radios transmitting with a CTCSS of 100.0. On these models, that requires squelch_mode to be SQ_TONE.

jdsteele commented 5 years ago

Fixed in #35

sergev commented 5 years ago

OK, I agree. I still don't understand why we need a separate squelch_mode bit, as we already have separate ctcss_receive and dcs_receive bits. But anyway, you are right. I'll merge your pull request #35. Thank you for the patch.

jdsteele commented 5 years ago

No problem. Glad I could help.

The on-radio menu for Squelch Mode, which presumably has a direct relationship to ch->squelchmode, actually has 5 entries. The documentation is vague, but it appears the other 3 entries are related to 2 Tone / 5 Tone signaling. I guess I can update the SQ constants, for clarity, once I verify the values.