In #17 I reported that the favicons were not loading, which is a minor UX impairment. The favicons existed, the index.html just had the wrong relative path. So fix that.
Why
With this, my naive link checker shows that there are no dead links on the openrtx.org page. Once this is done, I can explore integrating a GitHub Action to avoid introducing new dead links. So this change in itself is somewhat helpful, but it is also an incremental change towards adding some stability to this project.
How
Correct the relative path on the index.html file. This works because the files already exist and are being served properly.
silseva
commented
1 year ago
What
In #17 I reported that the favicons were not loading, which is a minor UX impairment. The favicons existed, the
index.htmljust had the wrong relative path. So fix that.Why
With this, my naive link checker shows that there are no dead links on the openrtx.org page. Once this is done, I can explore integrating a GitHub Action to avoid introducing new dead links. So this change in itself is somewhat helpful, but it is also an incremental change towards adding some stability to this project.
How
Correct the relative path on the
index.htmlfile. This works because the files already exist and are being served properly.So all that was needed was to add
/iconsto the hrefs.Verification
Expected result: the OpenRTX logo appears as the favicon (in chrome, this is left of the omnibar) Actual result: the OpenRTX logo appears