search

OpenRailAssociation / osrd-website

OSRD website (work in progress)
https://osrd.fr/
4 stars 12 forks source link

guides: deployment: add doc about ROOT_URL #199

Closed Castavo closed 3 weeks ago

multun commented 5 months ago

I'm pretty sure more changes are needed to deploy OSRD on the internet using docker-compose. The docker compose setup is designed for development only: no authentication is supported, the front-end is served in development mode (rebuilt on the fly).

I'm not comfortable suggesting this setup unless someone puts real effort into making it safe

Castavo commented 1 month ago

I added a commit about the limited purpose of the docker compose deployment method

Castavo commented 1 month ago

@ElysaSrc neat ! Then should I close the PR completely or keep it to add only the detail about the docker-compose deployment being a tad unsafe / not protection ready ?

ElysaSrc commented 1 month ago

@ElysaSrc neat ! Then should I close the PR completely or keep it to add only the detail about the docker-compose deployment being a tad unsafe / not protection ready ?

As you wish, adding a word about the docker compose deployment being unfit for production is a good idea.

Khoyo commented 3 weeks ago

I feel these changes are not required anymore since ROOT_URL is not used anymore : the gateway serves both on the same domain and the front uses a relative path

It shouldn't be, but it is... (editoast uses it to determine the url the layers are served from)

Castavo commented 3 weeks ago

Dang So it's a bug ?

Castavo commented 3 weeks ago

@ElysaSrc at least we can merge the warning

Khoyo commented 3 weeks ago

Discussed with @flomonster, ROOT_URL is still here because we can't give relative URLs to MapLibre... So it's probably here to stay

ElysaSrc commented 3 weeks ago

Yes since it's still in use you can merge the PR like it was the first time.

Sorry for the confusion.

Castavo commented 3 weeks ago

I re-added the part about ROOT_URL @ElysaSrc