OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
441 stars 39 forks source link

Pan/Zoom is not consistent for DataVizs (GET/GEV) #2774

Closed alexandredamiron closed 7 months ago

alexandredamiron commented 1 year ago

Description and goal

Zoom works on ctrl-wheel, while pan works only with shift-mousdown

reason: on mac, ctrl-click trigger browser contextuel menu (+ prevent provide and behavior is not correctly disable on button release)

Acceptance criteria

It is not convenient. Let's work with shift only

nicolaswurtz commented 1 year ago

I don't agree ! CTRL+Zoom is a common shortcut on whole operating systems, except MacOSX because... think different.

Here's my two cents, we keep actual behaviour:

For MacOSX, we should add a test to detect the OS and adapt shortcut. I'm not very familiar with MacOSX common shortcuts, but I think that Cmd is used in place of CTRL for the same shortcuts ? To be defined.

If test for OS is too heavy to be done inside a page, we could do it once for all in the head of the app and adapt shortcuts globally.

axrolld commented 1 year ago

Is there an agreement on @nicolaswurtz 's comment here ? Can we assign this issue to somebody or does it need more discussion ?

clarani commented 7 months ago

Will be fixed with the GET refacto